Skip to content

Conversation

hf
Copy link
Contributor

@hf hf commented Aug 22, 2025

Sad but true. Empty email address "send" was considered successful.

@hf hf requested a review from a team as a code owner August 22, 2025 11:30
@coveralls
Copy link

coveralls commented Aug 22, 2025

Pull Request Test Coverage Report for Build 17242085652

Details

  • 3 of 14 (21.43%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 70.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/external.go 0 3 0.0%
internal/api/identity.go 0 4 0.0%
internal/api/mail.go 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
internal/api/external.go 1 75.9%
Totals Coverage Status
Change from base Build 17191439812: -0.05%
Covered Lines: 12270
Relevant Lines: 17342

💛 - Coveralls

Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good to me. 👍

@hf
Copy link
Contributor Author

hf commented Aug 26, 2025

Keeping this for the next release.

@hf hf force-pushed the hf/fail-empty-address branch from 40f2a5d to e1e4ca5 Compare August 26, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants