-
-
Notifications
You must be signed in to change notification settings - Fork 77
feat: use orbstack for dev #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a69390d.
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Lines 775 to 787 in 0a99c66
| "volumes": [ | |
| { | |
| "name": REPLICATOR_CONFIG_FILE_VOLUME_NAME, | |
| "configMap": { | |
| "name": replicator_config_map_name | |
| } | |
| }, | |
| { | |
| "name": VECTOR_CONFIG_FILE_VOLUME_NAME, | |
| "configMap": { | |
| "name": VECTOR_CONFIG_MAP_NAME | |
| } | |
| }, |
Even for the development environment where vector is intentionally removed, the generated StatefulSet still defines a vector-config-file volume that references the replicator-vector-config ConfigMap. The dev init.sh only applies the namespace and trusted root certificates and never provisions that config map, so the pod will stay in CreateContainerConfigError because Kubernetes requires referenced ConfigMaps to exist even if no container mounts them. To let dev replicas start without vector, the volume (or at least the ConfigMap reference) needs to be omitted or made optional when running in Environment::Dev.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Pull Request Test Coverage Report for Build 19031873858Details
💛 - Coveralls |
Replicator images are now run in the orbstack k8s cluster instead of in the staging eks cluster during development. This removes the requirement for anyone who wants to develop ETL locally to have access to staging eks cluster. Sentry and vector (for logflare logs) are not configured for development. The init.sh script has also been updated to insert a default image into the database and to setup a minimum k8s environment needed to run a replicator. Currently the default image used (
ramsup/replicator:0.0.22) was build on my local machine and pushed to dockerhub manually because the multi-arch images built in CI do not run on macs.