Skip to content

Conversation

@imor
Copy link
Contributor

@imor imor commented Nov 1, 2025

Replicator images are now run in the orbstack k8s cluster instead of in the staging eks cluster during development. This removes the requirement for anyone who wants to develop ETL locally to have access to staging eks cluster. Sentry and vector (for logflare logs) are not configured for development. The init.sh script has also been updated to insert a default image into the database and to setup a minimum k8s environment needed to run a replicator. Currently the default image used (ramsup/replicator:0.0.22) was build on my local machine and pushed to dockerhub manually because the multi-arch images built in CI do not run on macs.

@imor imor marked this pull request as ready for review November 3, 2025 07:35
@imor imor requested a review from a team as a code owner November 3, 2025 07:35
@iambriccardo
Copy link
Contributor

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

etl/etl-api/src/k8s/http.rs

Lines 775 to 787 in 0a99c66

"volumes": [
{
"name": REPLICATOR_CONFIG_FILE_VOLUME_NAME,
"configMap": {
"name": replicator_config_map_name
}
},
{
"name": VECTOR_CONFIG_FILE_VOLUME_NAME,
"configMap": {
"name": VECTOR_CONFIG_MAP_NAME
}
},

P1 Badge Skip vector volume when logs collector is disabled

Even for the development environment where vector is intentionally removed, the generated StatefulSet still defines a vector-config-file volume that references the replicator-vector-config ConfigMap. The dev init.sh only applies the namespace and trusted root certificates and never provisions that config map, so the pod will stay in CreateContainerConfigError because Kubernetes requires referenced ConfigMaps to exist even if no container mounts them. To let dev replicas start without vector, the volume (or at least the ConfigMap reference) needs to be omitted or made optional when running in Environment::Dev.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@coveralls
Copy link

coveralls commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19031873858

Details

  • 294 of 318 (92.45%) changed or added relevant lines in 2 files are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 82.673%

Changes Missing Coverage Covered Lines Changed/Added Lines %
etl-api/src/k8s/http.rs 294 295 99.66%
etl-api/src/startup.rs 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
etl-postgres/src/tokio/test_utils.rs 4 89.97%
etl/src/replication/client.rs 20 85.83%
Totals Coverage Status
Change from base Build 19028682516: 0.2%
Covered Lines: 16055
Relevant Lines: 19420

💛 - Coveralls

@imor imor merged commit dbb2206 into main Nov 3, 2025
10 checks passed
@imor imor deleted the rs/use-orbstack-for-dev branch November 3, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants