fix: oas 3.1 schema expand/collapse not working on initial render #10639
+30
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
setExpanded()andsetCollapsed()callbacks were missingpathMutatorin theuseCallback()dependency array, meaning that there was a race condition on initial render when configured withdefaultModelRendering: "model".Switching from Schema -> Example Value -> Schema worked around the issue, but this PR fixes it so that the schema expansion works on first render without the workaround.
Motivation and Context
Fixes #10628
How Has This Been Tested?
Manually tested in local dev server by configuring the
dev-helper-initializer.jsfile as follows:Also added an e2e test to ensure that the expand collapse works on initial render.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests