Turn ENABLE_SDK_IMPORTS off by default for now (#196)

neonichu · web-flow · commit 68b0a58bf930 · 2025-02-19T14:18:53.000-08:00
diff --git a/Sources/SWBCore/Specs/CoreBuildSystem.xcspec b/Sources/SWBCore/Specs/CoreBuildSystem.xcspec
@@ -4467,7 +4467,7 @@ When this setting is enabled:
             {
                 Name = "ENABLE_SDK_IMPORTS";
                 Type = Boolean;
-                DefaultValue = "$(ASSETCATALOG_COMPILER_SKIP_APP_STORE_DEPLOYMENT:not)";
+                DefaultValue = "NO";
             },
         );
     },
diff --git a/Tests/SWBBuildSystemTests/SDKImportsBuildOperationTests.swift b/Tests/SWBBuildSystemTests/SDKImportsBuildOperationTests.swift
@@ -36,6 +36,7 @@ fileprivate struct SDKImportsBuildOperationTests: CoreBasedTests {
                     "CODE_SIGN_IDENTITY": "-",
                     "CODE_SIGN_ENTITLEMENTS": "Entitlements.plist",
                     "DEFINES_MODULE": "YES",
+                    "ENABLE_SDK_IMPORTS": "YES",
                     "GENERATE_INFOPLIST_FILE": "YES",
                     "PRODUCT_NAME": "$(TARGET_NAME)",
                     "SDKROOT": "$(HOST_PLATFORM)",
@@ -138,6 +139,7 @@ fileprivate struct SDKImportsBuildOperationTests: CoreBasedTests {
                         "ARCHS": "$(ARCHS_STANDARD)",
                         "CODE_SIGNING_ALLOWED": "NO",
                         "DEFINES_MODULE": "YES",
+                        "ENABLE_SDK_IMPORTS": "YES",
                         "GENERATE_INFOPLIST_FILE": "YES",
                         "PRODUCT_NAME": "$(TARGET_NAME)",
                         "SDKROOT": "$(HOST_PLATFORM)",

Original file line number	Diff line number	Diff line change
`@@ -4467,7 +4467,7 @@ When this setting is enabled:`
`4467`	`4467`	`{`
`4468`	`4468`	`Name = "ENABLE_SDK_IMPORTS";`
`4469`	`4469`	`Type = Boolean;`
`4470`		`- DefaultValue = "$(ASSETCATALOG_COMPILER_SKIP_APP_STORE_DEPLOYMENT:not)";`
	`4470`	`+ DefaultValue = "NO";`
`4471`	`4471`	`},`
`4472`	`4472`	`);`
`4473`	`4473`	`},`