Turn ENABLE_SDK_IMPORTS off by default for now
#196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
jakepetroules,
mhrawdon,
mirza-garibovic and
owenv
as code owners
Collaborator
Author
|
@swift-ci please test |
owenv
approved these changes
Feb 19, 2025
Collaborator
owenv
left a comment
owenv
left a comment
There was a problem hiding this comment.
LGTM. you might need a handful of extra test updates, I'm not sure
Collaborator
Author
|
I think other tests should be fine since we're using an old Xcode in CI which auto opts us out of this feature anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.