Fix/Cleanup some unnecessary build setting #9228
Conversation
daveinglis
commented
Oct 8, 2025
daveinglis
commented
- fix adding -lc++ to OTHER_LDFLAGS to match native build system.
- remove OTHER_LDRFLAGS setting
daveinglis
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
daveinglis
changed the title
|
@swift-ci test |
| // darwin & freebsd | ||
| if [.macOS, .macCatalyst, .iOS, .watchOS, .tvOS, .xrOS, .driverKit, .freebsd].contains(platform) { | ||
| settings[.OTHER_LDFLAGS, platform] = ["-lc++", "$(inherited)"] | ||
| } else if platform != .windows { // all others except windows |
There was a problem hiding this comment.
I wonder if we should warn or emit a debug log if we encounter a totally unknown platform here so we know we need to go fix it up
There was a problem hiding this comment.
I made the new test fail of it finds a unknown platform.
|
It might be nice to see if we can put in a test in SwiftBuildSupportTests/PIFBuilderTests for this |
- fix adding -lc++ to OTHER_LDFLAGS to match native build system. - remove OTHER_LDRFLAGS setting
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test linux |
| // We currently deliberately do not support Swift ObjC interface headers. | ||
| settings[.SWIFT_INSTALL_OBJC_HEADER] = "NO" | ||
| settings[.SWIFT_OBJC_INTERFACE_HEADER_NAME] = "" | ||
| settings[.OTHER_LDRFLAGS] = [] |
There was a problem hiding this comment.
Do we know why this was set? Could be a default value that this is explicitly wanting to clear out.
There was a problem hiding this comment.
I think it came over from the old PIF builder, not sure the history here.
| ) | ||
|
|
||
| if sourceModule.isCxx { | ||
| for platform in ProjectModel.BuildSettings.Platform.allCases { |
There was a problem hiding this comment.
On Windows, clang uses the MSVC C++ runtime, not libc++, right?
There was a problem hiding this comment.
looks like it, -lc++ was not found, and it look like the linker is adding the MSVC libraries as c++ packages seem to be building now
|
something weird happened with the PR where I could not update it anymore... here (#9234) is the new one and will close this one |
3 participants
