Skip to content

Allow home/end key default behavior inside ComboboxInput when Combobox is closed #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Allow home/end key default behavior inside ComboboxInput when Combobox is closed #3799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed58726
Don’t capture home/end keys if combobox is closed
thecrypticace Sep 18, 2025
1e571fb
Update changelog
thecrypticace Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@headlessui-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Don't accidentally open the `Combobox` when touching the `ComboboxButton` while dragging on mobile ([#3795](https://github.com/tailwindlabs/headlessui/pull/3795))
- Ensure sibling `Dialog` components are scrollable on mobile ([#3796](https://github.com/tailwindlabs/headlessui/pull/3796))
- Infer `Combobox` type based on `onChange` handler ([#3798](https://github.com/tailwindlabs/headlessui/pull/3798))
- Allow home/end key default behavior inside `ComboboxInput` when `Combobox` is closed ([#3798](https://github.com/tailwindlabs/headlessui/pull/3798))

## [2.2.8] - 2025-09-12

Expand Down
8 changes: 8 additions & 0 deletions packages/@headlessui-react/src/components/combobox/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,10 @@ function InputFn<
})

case Keys.Home:
if (machine.state.comboboxState === ComboboxState.Closed) {
break
}

if (event.shiftKey) {
break
}
Expand All @@ -748,6 +752,10 @@ function InputFn<
return machine.actions.goToOption({ focus: Focus.First })

case Keys.End:
if (machine.state.comboboxState === ComboboxState.Closed) {
break
}

if (event.shiftKey) {
break
}
Expand Down