Convert voluptuous schema to msgspec #752

abhishekmadan30 · 2025-08-26T15:16:44Z

No description provided.

src/taskgraph/util/schema.py

docs/concepts/transforms.rst

src/taskgraph/config.py

src/taskgraph/transforms/matrix.py

ahal

Thanks, this is shaping up nicely!

I don't think I have any other major concerns, it's mostly all nits and a minor changes. So I think you can go ahead and start converting Gecko without fear of a major new request (from me at least :p)

docs/concepts/transforms.rst

src/taskgraph/config.py

src/taskgraph/parameters.py

src/taskgraph/transforms/fetch.py

src/taskgraph/transforms/run/__init__.py

src/taskgraph/util/dependencies.py

src/taskgraph/util/schema.py

...utter.project_name}}/taskcluster/{{cookiecutter.project_slug}}_taskgraph/transforms/hello.py

ahal

Nice, thanks for the updates! I don't see any fundamental problems or anything, though I'll reserve the right to request future changes as we test this out in Gecko ;)

I'll avoid approving this for now because I want to hold off landing until we have a working patch for Gecko, but I think you can go ahead and get started on that! Hopefully claude or some clever macros can help with the conversion, because there's going to be a lot of schemas :)

ahal

I didn't get a chance to review the whole thing, but I'll leave the comments I had so far for now and resume tomorrow. Figured you might want to get a head start

docs/tutorials/creating-a-task-graph.rst

src/taskgraph/config.py

ahal

A few more comments, still not all the way through though.

src/taskgraph/parameters.py

ahal · 2025-09-18T17:55:16Z

src/taskgraph/transforms/docker_image.py

+    # List of package tasks this docker image depends on.
+    packages: Optional[List[str]] = None
+    # Information for indexing this build so its artifacts can be discovered.
+    index: Optional[Any] = None


You should import the schema from gecko_taskgraph.transforms.task and reference the index key there when we come across these "cross references".

src/taskgraph/transforms/fetch.py

src/taskgraph/transforms/from_deps.py

src/taskgraph/transforms/notify.py

src/taskgraph/transforms/run/__init__.py

src/taskgraph/transforms/run/run_task.py

src/taskgraph/transforms/task.py

ahal · 2025-09-25T18:05:48Z

Thanks, looks like you have some merge conflicts too. Please rebase and push your latest iteration and hopefully I can do one final review (of just the interdiff this time)

src/taskgraph/transforms/run/__init__.py

src/taskgraph/transforms/docker_image.py

src/taskgraph/transforms/fetch.py

ahal reviewed Aug 27, 2025

View reviewed changes

src/taskgraph/util/schema.py Outdated Show resolved Hide resolved

docs/concepts/transforms.rst Outdated Show resolved Hide resolved

src/taskgraph/config.py Show resolved Hide resolved

abhishekmadan30 marked this pull request as ready for review August 29, 2025 20:35

abhishekmadan30 requested a review from a team as a code owner August 29, 2025 20:35

abhishekmadan30 requested a review from ahal August 29, 2025 20:35

abhishekmadan30 changed the title ~~WIP: Convert voluptuous schema to taskgraph~~ Convert voluptuous schema to taskgraph Sep 2, 2025

abhishekmadan30 changed the title ~~Convert voluptuous schema to taskgraph~~ Convert voluptuous schema to msgspec Sep 2, 2025

ahal reviewed Sep 2, 2025

View reviewed changes

src/taskgraph/transforms/matrix.py Outdated Show resolved Hide resolved

abhishekmadan30 added the BREAKING CHANGE Backwards incompatible request that will require major version bump label Sep 2, 2025

ahal requested changes Sep 3, 2025

View reviewed changes

ahal reviewed Sep 5, 2025

View reviewed changes

ahal self-requested a review September 17, 2025 17:32

abhishekmadan30 force-pushed the schema-conversion branch from 87e0de9 to 750511c Compare September 17, 2025 19:01

ahal requested changes Sep 17, 2025

View reviewed changes

docs/tutorials/creating-a-task-graph.rst Outdated Show resolved Hide resolved

src/taskgraph/config.py Show resolved Hide resolved

src/taskgraph/config.py Show resolved Hide resolved

src/taskgraph/config.py Show resolved Hide resolved

ahal requested changes Sep 18, 2025

View reviewed changes

ahal reviewed Sep 18, 2025

View reviewed changes

ahal reviewed Sep 22, 2025

View reviewed changes

abhishekmadan30 force-pushed the schema-conversion branch 5 times, most recently from a1e336a to b936ea5 Compare September 29, 2025 22:21

ahal reviewed Oct 1, 2025

View reviewed changes

src/taskgraph/transforms/run/__init__.py Outdated Show resolved Hide resolved

ahal reviewed Oct 1, 2025

View reviewed changes

src/taskgraph/transforms/run/__init__.py Show resolved Hide resolved

ahal reviewed Oct 1, 2025

View reviewed changes

src/taskgraph/transforms/docker_image.py Show resolved Hide resolved

ahal reviewed Oct 1, 2025

View reviewed changes

src/taskgraph/transforms/fetch.py Show resolved Hide resolved

abhishekmadan30 force-pushed the schema-conversion branch from b936ea5 to 72b0151 Compare October 6, 2025 20:24

feat: update schema from voluptuous to msgspec

fcec021

abhishekmadan30 force-pushed the schema-conversion branch from 72b0151 to fcec021 Compare October 6, 2025 20:26

Convert voluptuous schema to msgspec #752

Are you sure you want to change the base?

Convert voluptuous schema to msgspec #752

Uh oh!

Conversation

abhishekmadan30 commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahal left a comment

Choose a reason for hiding this comment

Uh oh!

ahal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ahal Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahal commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!