-
Notifications
You must be signed in to change notification settings - Fork 48
ci: index docker-images by pull request number #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e5b343f
to
8728ebb
Compare
Example of how I'm using this: (I guess we don't even need to land this PR for my testing purposes, but might as well) |
4c73607
to
20c2b32
Compare
7364316
to
9b4feb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'm sold on this being something we need/want more generally.. so -0 from me.
Fair enough, I don't really care too much. Though keep in mind that in the future Gecko will be using the decision image rather than the gecko_decision image, so testing changes to the decision image cross repo will become more common. |
4f23f88
to
ac2a53c
Compare
I think I would like to get this landed as I keep alternating between rebasing onto this stack to test, and then rebasing off of it to get review. I've accidentally forgotten to rebase onto it a few times, resulting in me wasting time due to the wrong image getting used >< |
fe9f34e
to
e9fa779
Compare
Latest version of the patch makes this only apply to Taskgraph CI rather than everywhere. |
e9fa779
to
bc05f73
Compare
This will allow us to index tasks by pull request which can help testing changes in external repos.
bc05f73
to
b2831c2
Compare
This will make it easier to test out images (e.g, the Decision image) in other repos before we merge them in Taskgraph.