Teleport pipes bugfixes, code cleanup, and other misc bugfixes #203

Munchy907 · 2025-09-06T07:09:56Z

Included Rishum-P's Fix for Distribution Pipe Stall
Updated gradle minor version (keep in line with Buildcraft)
Added way to set player name with a gradle property
Made PipeBehaviorTeleport properties protected, and replaced direct calls to to them with getters & setters
Moved translation keys & nbt tag strings to there own classes
Fixed teleport pipes not reconnecting on chunk load
Fixed fake pipes being added to the teleport manger
Added a Pipe UUID to make equals() a lot easier
Move teleport side to PipeBehaviorTeleport from PipeBehaviorTeleportItem, and made it settable through the GUI
Added GUI button to set teleport side, default is Top
Moved owner name to a ledger, exactly like how Buildcraft engines work
Made pipes below colorable:

Advance Wood Pipe
Gravity Feed Pipe
Item Switch Pipe
Fluid Switch Pipe

Added back classic teleport pipe recipe
Fixed the GUI of Advanced Wood pipes
Bump version to 6.0.0.9

…lank for default forge naming, aka player + a random number 3-digit number that changes each time you runClient

…oaded like chunk loaded, DOES NOT include when the pipe is place). Commented out adding teleport pipe to teleport manager in the constructor as the pipe it added had no pipe behavior or IPipe defined yet, thus they would return null Made public none final class variables protected, and replaced all calls to the variables directly to getters and setters Added states enum so magic numbers aren't placed everywhere with comments having to explain them

Added a class that contains nbt tag strings, to remove hardcoded strings. Currently only for teleport pipes Added a class from my TeleportPipeRemade mod (was made to learn how everything for teleport pipes) currently contains translation key strings, to remove hardcoded strings. Very limited to one key in teleport pipe rn

…lass. Now teleport side is set in the GUI, and updates when they click the button in real time. Updated the gui to include a teleport side button as well as increased the blank background to suit fit this

…aft api's markForUpdate() from IPipe

Enabled coloring of: - Advance Wood Pipe - Gravity Feed Pipe - Item Switch Pipe - Fluid Switch Pipe Added back classic teleport pipe recipe Fixed the GUI of Advanced Wood pipes Bump version to 6.0.0.9

…er & gui size accordingly

Fixed teleport fluid pipes duping fluid that went into it. Though this issue is appears to down to buildcraft api's PipeEventFluid.OnMoveToCentre event.fluid and it's amount not always being accurate

Fixed teleport fluid pipes duping fluid that went into it. Though this issue is appears to down to buildcraft api's PipeEventFluid.OnMoveToCentre event.fluid and it's amount not always being accurate Bumped version

multiplemonomials · 2025-09-10T06:10:01Z

Question: Were you getting a bunch of asset download errors when running gradle commands? Because I think I figured out how to fix that

Munchy907 · 2025-09-10T06:49:27Z

It said it failed to download the assets one time, but I might of accidently fixed that issue when solving my IDE not being able to import from minecraft source, but at the same time it would build properly. Out of curiosity, how did you fix the asset download error? Will also help in the future if I come across it

multiplemonomials · 2025-09-10T08:09:24Z

That was fixed by switching to the fork of ForgeGradle!

Fixed teleport fluid pipes duping fluid that went into it. Though this issue is appears to down to buildcraft api's PipeEventFluid.OnMoveToCentre event.fluid and it's amount not always being accurate

…ly respectively

Bumped version to 6.0.0.11

multiplemonomials · 2025-09-10T06:31:34Z

src/main/java/buildcraft/additionalpipes/APPipeDefintions.java

 		itemsTeleportPipeItem = PipeCreator.createPipeItem(itemsTeleportPipeDef);	

-		// add assembly recipe for Item Teleport Pipe
+/*		// add assembly recipe for Item Teleport Pipe (Deprecated)


Wait why are we deprecating this?

I swapped back to the old recipe of 2 diamond gears, as I was unable to get the recipe to showup in jei. Works for normal buildcraft, but not add pipes

Ah yeah I have seen that, the recipe does work but doesn't show in JEI. Maybe could we open a bug for this and them come back to it later?

Swapped back and added buildcraft compat for jei support

build.gradle

multiplemonomials · 2025-09-27T17:47:35Z

build.gradle


 dependencies {
-	compile 'BuildCraft:buildcraft:7.99.24.1:dev'
+	implementation('BuildCraft:buildcraft:7.99.24.1:dev')


Looks like buildcraft actually just released the 8.0 release, should we try and update?

Yea, i've been flipping between buildcraft pre 8.0 release, 8.0 release, and buildcraft remastered. Will update to 8.0

Updated to 8.0

src/main/java/buildcraft/additionalpipes/AdditionalPipes.java

multiplemonomials · 2025-09-27T22:44:22Z

src/main/java/buildcraft/additionalpipes/gui/GuiTeleportPipe.java

+			super(GuiTeleportPipe.this.mainGui, OVERLAY_COLOR, true);
+			this.title = TranslationKeys.TELEPORT_LEDGER_OWNERSHIP;
+
+			appendText(() -> ((!Objects.equals(pipe.getOwnerName(), ""))? pipe.getOwnerName() : "no-one"), 0);


Should "no-one" be a localized string here?

I can at least help with the Japanese localization, the Japanese would be "だれも"

This code was taken from buildcrafts ownership ledger, but modified to work with pipes. But yea, seems like it's an oversight and should be localized string. Will fix that

Done. Added the Japanese localization as well

multiplemonomials · 2025-09-27T22:52:06Z

src/main/java/buildcraft/additionalpipes/pipes/PipeBehaviorDistribution.java

+
+
+					//Fix Stall
+					if (stackPartThisSide.stack.isEmpty()) {


Looking through the logic, I am really confused how this if statement could ever be true.

stackPartThisSide.stack has an item count equal to Math.min(getItemsLeftThisSide(), entry.stack.getCount())

getItemsLeftThisSide() must be greater than 0 or the check on line 97 would fail and then we would move to another side that accepts at least 1 item

entry.stack.getCount() must be greater than 0 or the check on line 95 would fail

So, the count of the new ItemEntry must be greater than 0

This was not me, I forked from https://github.com/Rishum-P/AdditionalPipesBC Which is what is used in tekkit 2 & tekkit smp. I'll mention him with this message in the tekkit 2 discord

I added this around three years ago to resolve an issue where Tekkit 2 servers were stalling due to the distribution pipe. It was an issue that affected basically every server at the time and led to the pipe being banned on practically every server. Eventually, malicious players began to exploit this to crash servers intentionally.

It was a long time ago, so I would have to review how it worked again and why the check is needed. When I added it, I was able to step through with debugging and hit it, but I'll get back to you on it.

Is Tekkit 2 a 1.12 pack? Or did it use an older additionalpipes version

Yes Minecraft 1.12.2. I'll grab reproduction steps tonight. If I remember it was trivial to do.

It's extremely easy to reproduce. All you need to do is break the pipe that the distribution pipe is transferring into while items are in transit, with no alternative route for the items to follow (i.e., other colours set to 0). You trigger a server stall (generated with sampler's stall reporting) with:

at net.minecraft.item.ItemStack.forgeInit(ItemStack.java:1291) at net.minecraft.item.ItemStack.<init>(ItemStack.java:129) at net.minecraft.item.ItemStack.func_77946_l(ItemStack.java:454) at buildcraft.additionalpipes.pipes.PipeBehaviorDistribution.splitStacks(PipeBehaviorDistribution.java:102) at java.lang.invoke.LambdaForm$DMH/608392736.invokeVirtual_LL_V(LambdaForm$DMH) at java.lang.invoke.LambdaForm$BMH/1634695718.reinvoke(LambdaForm$BMH) at java.lang.invoke.LambdaForm$MH/843164542.invoke_MT(LambdaForm$MH) at buildcraft.transport.pipe.PipeEventBus$LocalHandler.handleEvent(PipeEventBus.java:178) at buildcraft.transport.pipe.PipeEventBus.fireEvent(PipeEventBus.java:116) at buildcraft.transport.tile.TilePipeHolder.fireEvent(TilePipeHolder.java:524) at buildcraft.transport.pipe.flow.PipeFlowItems.onItemReachCenter(PipeFlowItems.java:313) at buildcraft.transport.pipe.flow.PipeFlowItems.onTick(PipeFlowItems.java:271) at buildcraft.transport.pipe.Pipe.onTick(Pipe.java:250) at buildcraft.transport.tile.TilePipeHolder.func_73660_a(TilePipeHolder.java:261) at net.minecraft.world.World.func_72939_s(World.java:2125) at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:742) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:978) at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:475) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:828) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:687) at java.lang.Thread.run(Thread.java:750)

It also occurs in single-player mode, but it crashes the client.

I have attached an example video here: https://streamable.com/ymzu3e (at the end the server has stalled and won't recover till its timeout time is hit and process killed)

There may be better ways to fix it than what i did, however, it was a quick fix at the time.

Ahh gotcha, thanks for the detailed example! I will look into this

multiplemonomials · 2025-09-27T22:55:57Z

src/main/java/buildcraft/additionalpipes/pipes/PipeBehaviorSwitch.java

 			canConnect = newCanConnect;
-			pipe.getHolder().scheduleNetworkUpdate(PipeMessageReceiver.BEHAVIOUR);
+			//pipe.getHolder().scheduleNetworkUpdate(PipeMessageReceiver.BEHAVIOUR);
+			pipe.markForUpdate();


Just curious, why was this changed? Also can we comment out the old code?

I cannot remember the technical reasoning. But old version would not give a block update meaning it would show the pipes either connected when it should be disconnected or vice versa.

I did comment out the old code?

*sorry, remove the commented code

Changed version to 6.0.0.9 Change http to https for have links Added back assembly table recipe, removed old recipe Updated jei to latest stable build Added Buildcraft Compat Removed commented out old code in PipeBehaviorSwitch Add localized string for no-one, which currently is only supported in en_us & ja_jp

xJon · 2025-10-04T00:02:28Z

Any chance this can be compatible with both BC mainstream (v8.0.0) and BC Remastered?

Munchy907 · 2025-10-05T19:50:47Z

We don't use anything that's exclusively in BC 8. So I see no reason why it wouldn't be compatible. Just to make sure, I added it to tekkit smp and checked and worked without issue

Rishum-P and others added 15 commits December 24, 2022 16:04

Fix Distribution Pipe Stall

7b3970f

Updated gradle minor version (keep in line with buildcraft)

cefbd3f

Added way to set player name with a gradle property (Leave variable b…

d68f1e9

…lank for default forge naming, aka player + a random number 3-digit number that changes each time you runClient

Moved teleport side to the base teleport behaviour from the item subc…

2c3fe7c

…lass. Now teleport side is set in the GUI, and updates when they click the button in real time. Updated the gui to include a teleport side button as well as increased the blank background to suit fit this

Added missed translations keys in GuiTeleportPipe

830f868

Fixed not setting default teleport side

59a4018

Swapped method of updating pipe about teleport side change to buildcr…

56ff006

…aft api's markForUpdate() from IPipe

Moved owner name to ledger, like how buildcraft engines work.

a2b8c3a

Enabled coloring of: - Advance Wood Pipe - Gravity Feed Pipe - Item Switch Pipe - Fluid Switch Pipe Added back classic teleport pipe recipe Fixed the GUI of Advanced Wood pipes Bump version to 6.0.0.9

Changed back to old background_adv_wood texture & updated the contain…

6a8be6c

…er & gui size accordingly

Updated forge version to 14.23.5.2847

f2603ca

Fixed teleport fluid pipes duping fluid that went into it. Though this issue is appears to down to buildcraft api's PipeEventFluid.OnMoveToCentre event.fluid and it's amount not always being accurate

Updated forge version to 14.23.5.2847

0a873ff

Fixed teleport fluid pipes duping fluid that went into it. Though this issue is appears to down to buildcraft api's PipeEventFluid.OnMoveToCentre event.fluid and it's amount not always being accurate Bumped version

Merge remote-tracking branch 'origin/master'

5b2173d

Fixes tcooc#197: Fixed switch pipes updating properly

a1dafa5

multiplemonomials and others added 10 commits September 10, 2025 10:14

Try to fix some build system issues

19e9142

Fix permissions

f4d86a7

Enable exclusiveContent

b447421

OK that didn't work...

a3d0bdd

Updated forge version to 14.23.5.2847

ca8e4df

Fixed teleport fluid pipes duping fluid that went into it. Though this issue is appears to down to buildcraft api's PipeEventFluid.OnMoveToCentre event.fluid and it's amount not always being accurate

Replaced deprecated compile and runtime, with implement and runtimeOn…

bd69721

…ly respectively

Merge branch 'master' into master

08d56ab

Fixed item teleport pipe recipe only giving 1 pipe instead of 8

b839e2d

Fixed item teleport pipe recipe only giving 1 pipe instead of 8

17eb278

Bumped version to 6.0.0.11

Merge remote-tracking branch 'origin/master'

c7d34a8

multiplemonomials reviewed Sep 27, 2025

View reviewed changes

Munchy907 added 3 commits September 28, 2025 17:18

Merge remote-tracking branch 'upstream/master'

1b0104c

Uncommented jei being added at runtime that was left commented

d60a790

Teleport pipes bugfixes, code cleanup, and other misc bugfixes #203

Are you sure you want to change the base?

Teleport pipes bugfixes, code cleanup, and other misc bugfixes #203

Uh oh!

Conversation

Munchy907 commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

multiplemonomials commented Sep 10, 2025

Uh oh!

Munchy907 commented Sep 10, 2025

Uh oh!

multiplemonomials commented Sep 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

multiplemonomials Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rishum-P Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rishum-P Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Munchy907 Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xJon commented Oct 4, 2025

Uh oh!

Munchy907 commented Oct 5, 2025

Uh oh!

Uh oh!

Munchy907 commented Sep 6, 2025 •

edited

Loading

multiplemonomials Sep 27, 2025 •

edited

Loading

Rishum-P Sep 30, 2025 •

edited

Loading

Rishum-P Sep 30, 2025 •

edited

Loading

Munchy907 Sep 28, 2025 •

edited

Loading