Standalone activity API sketches #1138
Conversation
dandavison
force-pushed
the
standalone-activity
branch
from
a1d3efe to
23df3f8
Compare
temporalio/client.py
Outdated
| self._id_or_token = ActivityIDReference(activity_id=id, run_id=run_id) | ||
| self.run_id = run_id | ||
|
|
||
| # TODO: do we support something like `follow_runs: bool`? |
There was a problem hiding this comment.
No need there's no concept of an execution chain for activities.
| handle = await self.start_activity(*args, **kwargs) | ||
| return await handle.result() | ||
|
|
||
| async def list_activities( |
There was a problem hiding this comment.
Would be interesting to see how we can model this to return both workflow and standalone "client" activities.
|
|
||
| # - TODO: Overloads for no-param, single-param, multi-param | ||
| # - TODO: Support sync and async activity functions | ||
| async def start_activity( |
There was a problem hiding this comment.
Also need execute_activity but we can leave that for later.
There was a problem hiding this comment.
Actually execute_activity is already present below.
temporalio/client.py
Outdated
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class AsyncActivityIDReference: |
There was a problem hiding this comment.
Consider deprecating and renaming to WorkflowActivityIDReference.
There was a problem hiding this comment.
Or merging the two reference types where workflow_id becomes an optional field.
temporalio/client.py
Outdated
| """Handle representing an activity started by a workflow.""" | ||
|
|
||
| def __init__( | ||
| self, client: Client, id_or_token: Union[AsyncActivityIDReference, bytes] |
There was a problem hiding this comment.
This should work with any activity IMHO.
temporalio/client.py
Outdated
| self._id_or_token = id_or_token | ||
|
|
||
|
|
||
| WorkflowActivityHandle = AsyncActivityHandle |
There was a problem hiding this comment.
This will also need pause, reset, etc...
There was a problem hiding this comment.
I think we still want AsyncActivityHandle because you can obtain one with a token and can't do anything else with the token but issue completion requests.
| """ | ||
| raise NotImplementedError | ||
|
|
||
| # TODO: |
There was a problem hiding this comment.
Also TODO: all of the async completion methods.
There was a problem hiding this comment.
You mean heartbeat, complete, fail, and report_cancellation, right? Those are all inherited from _BaseActivityHandle.
There was a problem hiding this comment.
I'm on the fence whether we want to expose these methods on the activity handle as opposed to having the async completion handle as a separate concept. The use cases are different for the two.
temporalio/client.py
Outdated
| ) | ||
|
|
||
|
|
||
| # TODO: This name is suboptimal now. We could deprecate it and introduce WorkflowActivityHandle as a |
There was a problem hiding this comment.
Yeah, let's do that. Which means that you would have to accept a WorkflowActivityHandle where you accept AsyncActivityHandle.
temporalio/client.py
Outdated
|
|
||
| class AsyncActivityHandle: | ||
| """Handle representing an external activity for completion and heartbeat.""" | ||
| class _BaseActivityHandle: |
There was a problem hiding this comment.
I would consider just duplicating instead of inheriting but don't have a strong opinion.
dandavison
force-pushed
the
standalone-activity
branch
from
2f29d96 to
519a359
Compare
dandavison
force-pushed
the
standalone-activity
branch
from
4760964 to
0904987
Compare
No description provided.