-
Notifications
You must be signed in to change notification settings - Fork 314
Depend on serde_core
instead of serde
#797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. The serde_core
package must be new. This is the first time I heard about it.
579784e
to
dcd6fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
CI |
Maybe the old version resolver wasn't as smart as the new one. Does it work locally if you let a more modern version (but not too modern that it uses the newer Cargo.lock format) generate the lockfile? |
This crate does not make use of serde derive macros, thus it can depend on `serde_core` instead of `serde` to speed up users' compile times. See the documentation of [`serde_core`](https://docs.rs/serde_core) for more details.
dcd6fe7
to
16a496a
Compare
I doubt it. Not really sure what we can do about it rather than raise the msrv. |
I've tried generating the lockfile with Rust v1.63 and then running Rust v1.57 to see it would fix the issue, and it does, but then a similar second error comes out. I've tested all versions between v1.57 and 1.63, and v1.60 is the first one that works. Other than the Yocto Kirkstone 1 people, I don't expect anyone else to possibly complain for the MSRV bump. Footnotes
|
This crate does not make use of serde derive macros, thus it can depend on
serde_core
instead ofserde
to speed up users' compile times.See the documentation of
serde_core
for more details.Note that this adds a hiddenserde_core
feature, since we cannot use thedep:
syntax when declaring theserde
feature due to this crate's MSRV being lower than the required 1.60.