Update protobuf-src example to avoid unsafe set_var #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation under "Compiling
protoc
from source" to avoid using unsafestd::env::set_var
.std::env::set_var
becomes unsafe in Rust 2024 unless certain strict single-threaded conditions are met. While we could wrap the call in anunsafe
block, introducingunsafe
just for setting an environment variable isn't worth the added complexity. Instead, the example now uses theprost_build::Config::protoc_executable
method to directly set the path to theprotoc
binary.