Skip to content

tracing: fix perf regression when release_max_level_* not set #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tracing: fix perf regression when release_max_level_* not set #3373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions tracing/src/level_filters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,36 @@ pub use tracing_core::{metadata::ParseLevelFilterError, LevelFilter};
pub const STATIC_MAX_LEVEL: LevelFilter = get_max_level_inner();

const fn get_max_level_inner() -> LevelFilter {
if cfg!(not(debug_assertions)) {
if cfg!(feature = "release_max_level_off") {
LevelFilter::OFF
} else if cfg!(feature = "release_max_level_error") {
LevelFilter::ERROR
} else if cfg!(feature = "release_max_level_warn") {
LevelFilter::WARN
} else if cfg!(feature = "release_max_level_info") {
LevelFilter::INFO
} else if cfg!(feature = "release_max_level_debug") {
LevelFilter::DEBUG
} else {
// Same as branch cfg!(feature = "release_max_level_trace")
LevelFilter::TRACE
}
if cfg!(all(
not(debug_assertions),
feature = "release_max_level_off"
)) {
LevelFilter::OFF
} else if cfg!(all(
not(debug_assertions),
feature = "release_max_level_error"
)) {
LevelFilter::ERROR
} else if cfg!(all(
not(debug_assertions),
feature = "release_max_level_warn"
)) {
LevelFilter::WARN
} else if cfg!(all(
not(debug_assertions),
feature = "release_max_level_info"
)) {
LevelFilter::INFO
} else if cfg!(all(
not(debug_assertions),
feature = "release_max_level_debug"
)) {
LevelFilter::DEBUG
} else if cfg!(all(
not(debug_assertions),
feature = "release_max_level_trace"
)) {
LevelFilter::TRACE
} else if cfg!(feature = "max_level_off") {
LevelFilter::OFF
} else if cfg!(feature = "max_level_error") {
Expand Down
Loading