Skip to content

expose BuildSingleGSAdapter for enterprise feature #9562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

expose BuildSingleGSAdapter for enterprise feature #9562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/block/factory/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ func BuildGSClient(ctx context.Context, params params.GS) (*storage.Client, erro

func buildGSAdapter(ctx context.Context, params params.GS, adapterOpts ...gs.AdapterOption) (block.Adapter, error) {
if params.DataCredentialsJSON == "" && params.DataCredentialsFile == "" {
return buildSingleGSAdapter(ctx, params, adapterOpts...)
return BuildSingleGSAdapter(ctx, params, adapterOpts...)
}

metadataAdapter, err := buildSingleGSAdapter(ctx, params, adapterOpts...)
metadataAdapter, err := BuildSingleGSAdapter(ctx, params, adapterOpts...)
if err != nil {
return nil, fmt.Errorf("failed to create metadata adapter: %w", err)
}
Expand All @@ -182,7 +182,7 @@ func buildGSAdapter(ctx context.Context, params params.GS, adapterOpts ...gs.Ada
dataParams.CredentialsFile = params.DataCredentialsFile
dataParams.CredentialsJSON = params.DataCredentialsJSON

dataAdapter, err := buildSingleGSAdapter(ctx, dataParams, adapterOpts...)
dataAdapter, err := BuildSingleGSAdapter(ctx, dataParams, adapterOpts...)
if err != nil {
return nil, fmt.Errorf("failed to create data adapter: %w", err)
}
Expand All @@ -193,8 +193,8 @@ func buildGSAdapter(ctx context.Context, params params.GS, adapterOpts ...gs.Ada
return dualAdapter, nil
}

// buildSingleGSAdapter creates a single GS adapter (extracted from original buildGSAdapter)
func buildSingleGSAdapter(ctx context.Context, params params.GS, adapterOpts ...gs.AdapterOption) (*gs.Adapter, error) {
// BuildSingleGSAdapter creates a single GS adapter (extracted from original buildGSAdapter)
func BuildSingleGSAdapter(ctx context.Context, params params.GS, adapterOpts ...gs.AdapterOption) (*gs.Adapter, error) {
client, err := BuildGSClient(ctx, params)
if err != nil {
return nil, err
Expand Down
Loading