fix crash during torch model reload with inter op thread parameter set #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snadampal
changed the title
gerilya
reviewed
Sep 30, 2025
There was a problem hiding this comment.
During model reload the call to set inter_op value will be skipped altogether, however, nothing will be logged.
From the user perspective, it might create a confusion as to what inter_op value is used internally by Pytorch backend.
I would suggest taking LOG_MESSAGE out of the conditon, so inter_op_thread_count value is always logged whether setting it skipped or not.
torch allows setting the interop thread count only once and before any inter-op parallel work is started because it creates threadpool statically. To follow this constraint, check the interop thread count and set only if it's not yet set.
snadampal
force-pushed
the
fix_crash_during_model_reload
branch
from
46e7f68 to
b5a7410
Compare
|
@gerilya thanks for the feedback. I have made the LOG_MESSAGE unconditional so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch allows setting the interop thread count only once and before any inter-op parallel work is started because it creates threadpool statically.
To follow this constraint, check the interop thread count and set only if it's not yet set.