Add analyze BDD #381
Add analyze BDD #381
Conversation
krishnangovindraj
force-pushed
the
add-analyze-bdd
branch
from
73e2242 to
3614fd9
Compare
krishnangovindraj
force-pushed
the
add-analyze-bdd
branch
from
8f2975a to
82439ce
Compare
|
|
||
| Scenario: Errors in the query are returned as errors | ||
| Given connection open read transaction for database: typedb | ||
| When typeql analyze query; parsing fails |
There was a problem hiding this comment.
I think Cole's commentary is reflecting something accurate: analyze() shouldn't throw an error, but it should return an error. I think we do unify this in the service layer anyway right? So this could be generically "fails with message containing..."?
| [thing([person])], | ||
| stream([thing([name])]), |
There was a problem hiding this comment.
if we introduce polymorphic/inferred function argument annotations this will also work nicely
| """ | ||
| { | ||
| name: [string], | ||
| ref: [integer] |
There was a problem hiding this comment.
Im guessing these are all representing optionals right? Eg could be name-string or missing
There was a problem hiding this comment.
No, that's still a list of types. I haven't actually considered optionals because type-inference doesn't either.
It's not even returned by the analyze endpoint.
| """ | ||
| Pipeline([ | ||
| Match([ | ||
| Isa($p, person), |
There was a problem hiding this comment.
It would match the 'Annotations' to call this 'Trunk' (though my other comment suggests "And" or "Constraints" or "Statements"!)
There was a problem hiding this comment.
We encode Or, Not, Try as constraints, so here we don't need that.
flyingsilverfin
left a comment
flyingsilverfin
left a comment
There was a problem hiding this comment.
Approved, but please do check the 1 naming change before merging anything!
## Product change and motivation Tests the query structure returned by the analyze endpoint (and used by studios' graph visualizer) ## Implementation * Implements steps & functor encoding used in typedb/typedb-behaviour#381 * Small fixes around.
2 participants
Usage and product changes
Adds test for the query structure and annotations returned by the analyze endpoint