-
Notifications
You must be signed in to change notification settings - Fork 37
Fix transaction on_close and Java and Python block on close() #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flyingsilverfin
wants to merge
27
commits into
master
Choose a base branch
from
improve-on-close-callback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e907782
Improve Rust on_close_callback
flyingsilverfin a87a9d7
Trigger CI
flyingsilverfin df3ba3a
Deploy snapshot
flyingsilverfin b1b3f5b
Fix build
flyingsilverfin ebf41f5
Include mutex
flyingsilverfin cbf1d84
Fix drop behaviour
flyingsilverfin 9e94c90
Trigger CI
flyingsilverfin a3bbf3a
Use built-in Python 3.11 in mac jobs
flyingsilverfin a789e6e
Use builtin python3
flyingsilverfin 614705d
Add printlns
flyingsilverfin 5b1cb74
Establish close() as an async, non-dropping behaviour and drop as a s…
flyingsilverfin 308d290
Add configurable logging
flyingsilverfin fcee68b
Put logging init into correct place
flyingsilverfin b9e9468
More logging
flyingsilverfin 386397e
Even more logging
flyingsilverfin e462baa
Even even more logging
flyingsilverfin f0a6ba2
Try AI fix
flyingsilverfin d5a3c9e
Move wait
flyingsilverfin 2cee8dd
WIP diagnostic forced error
flyingsilverfin bf3f454
Try channel keepalives
flyingsilverfin 9b58f9a
Fix connection/transaction close race
flyingsilverfin 495324a
Fmt
flyingsilverfin 65a4141
Try with just keepalive when idle
flyingsilverfin 7eb2094
Cleanup
flyingsilverfin 3258c17
Try 10s keepalive
flyingsilverfin 6dd3128
Final cleanup
flyingsilverfin 0955701
Remove CircleCI publishing
flyingsilverfin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,7 +100,6 @@ commands: | |
type: string | ||
steps: | ||
- run: | | ||
brew install [email protected] | ||
curl -OL "https://github.com/bazelbuild/bazelisk/releases/download/v1.17.0/bazelisk-darwin-<<parameters.bazel-arch>>" | ||
sudo mv "bazelisk-darwin-<<parameters.bazel-arch>>" /usr/local/bin/bazel | ||
chmod a+x /usr/local/bin/bazel | ||
|
@@ -149,15 +148,14 @@ commands: | |
steps: | ||
- install-brew-rosetta | ||
- run: | | ||
/usr/local/bin/brew install [email protected] | ||
tool/test/start-community-server.sh | ||
/usr/local/bin/python3.9 -m pip install wheel | ||
/usr/local/bin/python3.9 -m pip install pip==21.3.1 | ||
/usr/local/bin/python3.9 -m pip install -r python/requirements_dev.txt | ||
/usr/local/bin/python3.9 -m pip install --extra-index-url https://repo.typedb.com/public/public-snapshot/python/simple typedb-driver==0.0.0+$(git rev-parse HEAD) | ||
python3 -m pip install wheel | ||
python3 -m pip install pip==21.3.1 | ||
python3 -m pip install -r python/requirements_dev.txt | ||
python3 -m pip install --extra-index-url https://repo.typedb.com/public/public-snapshot/python/simple typedb-driver==0.0.0+$(git rev-parse HEAD) | ||
sleep 5 | ||
pushd python/tests/deployment/ | ||
/usr/local/bin/python3.9 -m unittest test && export TEST_SUCCESS=0 || export TEST_SUCCESS=1 | ||
python3 -m unittest test && export TEST_SUCCESS=0 || export TEST_SUCCESS=1 | ||
popd | ||
tool/test/stop-community-server.sh | ||
exit $TEST_SUCCESS | ||
|
@@ -850,32 +848,32 @@ workflows: | |
- deploy-snapshot-linux-arm64: | ||
filters: | ||
branches: | ||
only: [development, master, "3.0"] | ||
only: [development, master] | ||
|
||
- deploy-snapshot-linux-x86_64: | ||
filters: | ||
branches: | ||
only: [development, master, "3.0"] | ||
only: [development, master] | ||
|
||
- deploy-snapshot-mac-arm64: | ||
filters: | ||
branches: | ||
only: [development, master, "3.0"] | ||
only: [development, master] | ||
|
||
- deploy-snapshot-mac-x86_64: | ||
filters: | ||
branches: | ||
only: [development, master, "3.0"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused |
||
only: [development, master] | ||
|
||
- deploy-snapshot-windows-x86_64: | ||
filters: | ||
branches: | ||
only: [development, master, "3.0"] | ||
only: [development, master] | ||
|
||
- deploy-snapshot-any: | ||
filters: | ||
branches: | ||
only: [development, master, "3.0"] | ||
only: [development, master] | ||
requires: | ||
- deploy-snapshot-linux-arm64 | ||
- deploy-snapshot-linux-x86_64 | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes mac build issues