-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add RefreshTopologyFromInitialNodes #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the RefreshTopologyFromInitialNodes configuration option for cluster clients, enabling topology updates to query only the initial nodes instead of the internal cluster view. It also updates the VS Code default solution setting.
- Adds
RefreshTopologyFromInitialNodesproperty andWithRefreshTopologyFromInitialNodes()method toClusterClientConfigurationBuilder - Threads the new boolean configuration through the internal FFI structs and connection configuration
- Updates VS Code workspace settings to use the correct solution file name
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Valkey.Glide.UnitTests/ConnectionConfigurationTests.cs | Adds unit tests verifying the default, true, and false values of RefreshTopologyFromInitialNodes |
| sources/Valkey.Glide/Internals/FFI.structs.cs | Adds the refreshTopologyFromInitialNodes parameter to the FFI ConnectionConfig and ConnectionRequest structs |
| sources/Valkey.Glide/ConnectionConfiguration.cs | Adds the RefreshTopologyFromInitialNodes property and builder method to ClusterClientConfigurationBuilder, plus updates the internal config record |
| .vscode/settings.json | Updates the default solution file name from "csharp.sln" to "Valkey.Glide.sln" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a83f4b7 to
a16c178
Compare
a16c178 to
d60bab5
Compare
…uct. Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
d60bab5 to
34caecc
Compare
Signed-off-by: currantw <[email protected]>
Add RefreshTopologyFromInitialNodes Configuration Option
Overview
This PR adds support for the
RefreshTopologyFromInitialNodesconfiguration option, enabling cluster topology refresh using only the initial seed nodes rather than the internal cluster view.Changes
ClusterClientConfigurationBuilder: AddedRefreshTopologyFromInitialNodesboolean property with default valuefalse, withWithRefreshTopologyFromInitialNodes(bool)fluent builder method.ConnectionConfig: Updated internal record to includeRefreshTopologyFromInitialNodesfield.FFI.ConnectionConfig: Updated constructor to accept and pass the configuration value to the native layer.ConnectionRequest: Added properly marshalled boolean field for FFI.ConnectionConfigurationTests: New test class with coverage for topology refreshConsistency
This implementation follows the same patterns established in other language clients:
Checklist