Skip to content

Conversation

@wenfengwang
Copy link
Contributor

@wenfengwang wenfengwang commented Jun 24, 2022

What problem does this PR solve?

Issue Number: close #110

Problem Summary:

In the implementation of before, we hard code controller information in vsctl codebase, the PR introduce controller proxy to resolve this problem.

What is changed and how it works?

use https://github.com/mwitkow/grpc-proxy as the reverse proxy to transport all grpc requests from vsctl to leader.

but due to https://github.com/mwitkow/grpc-proxy seems long time not maintaining, and the project have bug of mwitkow/grpc-proxy#62, I have to fork it and take that PR's changes to our fork: https://github.com/linkall-labs/grpc-proxy .

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    The vsctl has been tested paas based this PR

  • No code

@wenfengwang wenfengwang marked this pull request as draft June 24, 2022 13:07
@wenfengwang wenfengwang changed the title Issue 110 feat: add controller proxy for vsctl communication Jun 24, 2022
@wenfengwang wenfengwang marked this pull request as ready for review June 24, 2022 15:00
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #117 (09a90b0) into main (5bb2f51) will increase coverage by 0.23%.
The diff coverage is 61.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   47.81%   48.05%   +0.23%     
==========================================
  Files          99      100       +1     
  Lines        8256     8391     +135     
==========================================
+ Hits         3948     4032      +84     
- Misses       4014     4052      +38     
- Partials      294      307      +13     
Impacted Files Coverage Δ
internal/controller/eventbus/controller.go 0.00% <0.00%> (ø)
internal/gateway/gateway.go 0.00% <0.00%> (ø)
internal/gateway/grpc_proxy.go 63.15% <63.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb2f51...09a90b0. Read the comment docs.

@wenfengwang
Copy link
Contributor Author

wenfengwang commented Jun 25, 2022

@xdlbdy I created the issue #119 for tracing the problem you appointed.

@wenfengwang wenfengwang requested a review from xdlbdy June 25, 2022 13:02
xdlbdy
xdlbdy previously approved these changes Jun 25, 2022
@wenfengwang wenfengwang merged commit cae0d9b into main Jun 27, 2022
@wenfengwang wenfengwang deleted the issue-110 branch June 27, 2022 06:17
wenfengwang added a commit that referenced this pull request Mar 23, 2023
* feat: add proxy for the controller in gateway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix ip 192.168.49.2

4 participants