-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add controller proxy for vsctl communication #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 47.81% 48.05% +0.23%
==========================================
Files 99 100 +1
Lines 8256 8391 +135
==========================================
+ Hits 3948 4032 +84
- Misses 4014 4052 +38
- Partials 294 307 +13
Continue to review full report at Codecov.
|
xdlbdy
reviewed
Jun 25, 2022
xdlbdy
reviewed
Jun 25, 2022
xdlbdy
reviewed
Jun 25, 2022
xdlbdy
reviewed
Jun 25, 2022
xdlbdy
previously approved these changes
Jun 25, 2022
ifplusor
reviewed
Jun 27, 2022
ifplusor
approved these changes
Jun 27, 2022
xdlbdy
approved these changes
Jun 27, 2022
wenfengwang
added a commit
that referenced
this pull request
Mar 23, 2023
* feat: add proxy for the controller in gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #110
Problem Summary:
In the implementation of before, we hard code controller information in vsctl codebase, the PR introduce controller proxy to resolve this problem.
What is changed and how it works?
use https://github.com/mwitkow/grpc-proxy as the reverse proxy to transport all grpc requests from vsctl to leader.
but due to https://github.com/mwitkow/grpc-proxy seems long time not maintaining, and the project have bug of mwitkow/grpc-proxy#62, I have to fork it and take that PR's changes to our fork: https://github.com/linkall-labs/grpc-proxy .
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
The vsctl has been tested paas based this PR
No code