feat(mqtt source): support multiple mqtt source topics #23670
+101
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
domain: sources
|
+1 |
december1981
changed the title
december1981
changed the title
thomasqueirozb
changed the title
thomasqueirozb
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Thanks for the contribution, this makes sense. Tests always appreciated :)
@pront can you take a look too?
github-actions
bot
added
the
domain: external docs
estherk15
approved these changes
Aug 29, 2025
| } | ||
| topic: { | ||
| description: "MQTT topic from which messages are to be read." | ||
| description: "MQTT topic or topics from which messages are to be read." |
There was a problem hiding this comment.
Suggested change
| description: "MQTT topic or topics from which messages are to be read." | |
| description: "MQTT topic(s) from which messages are read." |
There was a problem hiding this comment.
I don't mind either way. I wrote it as topic or topics to make it a bit clearer that it could be specified as one or many (not just a single item of many for the former case)
|
I'm going to update the mqtt integration tests today then, as this PR appears to be approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It would be good to be able to subscribe to multiple mqtt topics where we'd want to subscribe with eg
prefix-1/#andprefix-2/#mqtt topic specs, without receiving data from the broker with topics beginning withprefix-3...(which would be a side effect of subscribing with the one topic spec string#).This change doesn't break current tests, but I've held off on adding any new tests in case this PR will not be approved.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.