Skip to content

Conversation

pront
Copy link
Member

@pront pront commented Sep 2, 2025

Summary

Move changelog validation to vdev.

(We leverage bininstall for vdev now)

In the future we can also rewrite the relevant scripts/generate-release-cue.rb bits in Rust.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Sep 2, 2025
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Sep 2, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Sep 2, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f917ff1 | Docs | Was this helpful? Give us feedback!

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 2, 2025
@pront pront force-pushed the pront-convert-changelog-fragments-to-rust branch from 1f9b6af to 0bb7e05 Compare September 3, 2025 20:08
@pront pront force-pushed the pront-convert-changelog-fragments-to-rust branch from 0bb7e05 to 1e4a6f9 Compare September 3, 2025 20:09
@pront pront removed the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 3, 2025
@pront pront marked this pull request as ready for review September 3, 2025 20:13
@pront pront requested a review from a team as a code owner September 3, 2025 20:13
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 3, 2025
@pront pront enabled auto-merge September 3, 2025 20:21
@pront pront disabled auto-merge September 3, 2025 20:21
@thomasqueirozb thomasqueirozb removed the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 4, 2025
sparse-checkout: changelog.d/
sparse-checkout: |
changelog.d/
scripts/environment/prepare.sh # FIXME DO NOT MERGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: this change needs to be reverted before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: vdev Anything related to the vdev tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants