Skip to content

Conversation

pront
Copy link
Member

@pront pront commented Sep 11, 2025

Summary

TODO: to avoid breaking existing code, need to add 'nats-fips' and 'nats-ring'

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Related: #16535
Related: #8435

Related: #22543

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Sep 11, 2025
pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

pront

This comment was marked as outdated.

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Sep 12, 2025

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

sinks::nats::integration_tests::nats_tls_client_cert_invalid from vector (Datadog)
Test has failed
sinks::nats::integration_tests::nats_tls_client_cert_valid from vector (Datadog)
Test has failed
sinks::nats::integration_tests::nats_tls_invalid from vector (Datadog)
Test has failed
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8655ec7 | Docs | Was this helpful? Give us feedback!

Copy link
Member Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-cross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant