-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(prometheus_remote_write source): ignore conflicting metadata instead of returning HTTP 400 #23773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elohmeier
wants to merge
7
commits into
vectordotdev:master
Choose a base branch
from
elohmeier:ignore-prom-meta-conflicts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(prometheus_remote_write source): ignore conflicting metadata instead of returning HTTP 400 #23773
elohmeier
wants to merge
7
commits into
vectordotdev:master
from
elohmeier:ignore-prom-meta-conflicts
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23f098e
to
7834aa8
Compare
Added missing authors to changelog file. |
pront
reviewed
Sep 16, 2025
8 tasks
…ead of returning HTTP 400 Previously, Vector would return HTTP 400 errors when receiving Prometheus remote write requests with conflicting metric metadata (e.g., same metric family declared as both COUNTER and GAUGE). This behavior differs from Prometheus and Thanos, which silently ignore metadata conflicts. This change modifies the prometheus-parser to use a "first-wins" strategy for conflicting metadata. cargo fmt add metadata_conflics option
61f0d2b
to
243ad9e
Compare
Rebased onto latest master and resolved the conflicts. |
pront
reviewed
Sep 17, 2025
@pront - is there anything I can do to get this over the finish line? This is currently affecting a larger client unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix HTTP 400 errors when Prometheus sends conflicting metric metadata by aligning Vector behavior with Prometheus/Thanos (silently ignore conflicts, continue processing timeseries data).
Vector configuration
How did you test this PR?
I've collected HTTP payloads from a Prometheus server configured to remote write to the Vector source via mitmproxy and replayed them to test.
Prometheus sent metadata payloads with e.g. this (protobuf/snappy encoded) v1 remote write Payload:
Which would lead to this error in Vector without our fix:
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.make fmt
make check-clippy
(if there are failures it's possible some of them can be fixed withmake clippy-fix
)make test
git merge origin master
andgit push
.Cargo.lock
), pleaserun
make build-licenses
to regenerate the license inventory and commit the changes (if any). More details here.