Skip to content

Address remaining comments from #3281 #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

Address remaining comments from #3281 #3289

merged 4 commits into from
Oct 2, 2025

Conversation

soheilshahrouz
Copy link
Contributor

Addresses Vaughn's comments from #3281

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code labels Sep 30, 2025
@soheilshahrouz
Copy link
Contributor Author

soheilshahrouz commented Sep 30, 2025 •
edited
Loading

@vaughnbetz Can you please take a quick look at this to see if all your comments are addressed?

@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz If you don't have any further comments, can I merge this?

AlexandreSinger
AlexandreSinger approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaughnbetz
vaughnbetz approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest one minor addition; after that it's good to merge.

@vaughnbetz vaughnbetz merged commit 0741b49 into master Oct 2, 2025
30 checks passed
@vaughnbetz vaughnbetz deleted the temp_org_rr_g_remaining_comments branch October 2, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz approved these changes

@AlexandreSinger AlexandreSinger AlexandreSinger approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soheilshahrouz @vaughnbetz @AlexandreSinger