-
Notifications
You must be signed in to change notification settings - Fork 247
[Dependencies] update lm_eval
version pin
#1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Brian Dellabetta <[email protected]>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @brian-dellabetta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a reported dependency conflict between Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request loosens the version constraints for datasets
and lm_eval
to resolve a dependency conflict. While the changes achieve the immediate goal, they introduce potential long-term maintenance and stability risks. My review includes a high-severity comment about the datasets
dependency spanning multiple major versions, which is a significant maintenance concern. I've also added a medium-severity comment suggesting a safer version constraint for the lm_eval
development dependency to improve build stability, along with a code suggestion.
Thanks Brian. We used to hit errors with |
@brian-dellabetta I ran the nightly, e2e and lm eval tests with the PR (using datasets 3.6.0) and tests look fine except for some known failures so I think the changes look good. The runs are here: |
Thanks @dhuangnm for testing it out! It does look like there are some errors related to datasets -- https://github.com/neuralmagic/llm-compressor-testing/actions/runs/17981209012/job/51147473913#step:12:21470
I actually ran into this today running lm_eval with datasets<4.0. So I think we need to stick to datasets >=4.0. I will raise a ticket on |
You're right @brian-dellabetta , good catch on the error. Sorry I missed these last few failures in the nightly job, strange when I searched error in the job originally they didn't show up but now I do remember seeing this error before when we had to pin the datasets in the last release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's switch back to "datasets>=4.0.0" due to the error.
Signed-off-by: Brian Dellabetta <[email protected]>
bd4e792
datasets
v3 for lm_eval
version compatibilitylm_eval
version pin
Thanks @dhuangnm , I updated this PR to just update the lm_eval dev pin, to be more in line with the other dev version pins. Will instead try to resolve the user issue by raising a ticket on lm_eval to support datasets>=4.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brian, LGTM!
SUMMARY:
A user reported in #1848 that our version pin for
datasets
is incompatible withlm_eval
, a dev dependency that is often used in tandem withllm-compressor
to eval compressed models.After trying with datasets 3.6.0, we have found that datasets<4.0 breaks tests with the following error:
so i will instead raise an issue in lm_eval. This PR now just loosens our dev restriction on
lm_eval
version, necessary for new tasks likearc_challenge_llama
.TEST PLAN:
n/a