Refactor/understanding prepare inputs padded #25758
Draft
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to understand how prepare_inputs() works.
prepare_inputs_padded()
states that it updatescommon_attn_metadata
. However, the code seems rather to make a copy only.common_attn_metadata
. Its has no negative impact.pytest tests/v1/spec_decode/test_eagle.py
all tests pass (some are skipped).=== 29 passed, 20 skipped, 2 warnings in 44.02s ===
pytest tests/v1/e2e/test_spec_decode.py -k test_eagle_correctness -s
, all tests pass (some are skipped).Am I missing something? If not this is an opportunity to simplify the
prepare_inputs_padded()
method.