Skip to content

[wip] Add row_id support to DuckDB #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

[wip] Add row_id support to DuckDB #3949

wants to merge 10 commits into from

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Jul 21, 2025

Blocked on:

  • MultiScan takes (LayoutReaderFactory, row_count) as input and constructs the scan itself?
  • MultiScan blocks waiting to configure row_idx of child scans. Factories run in parallel, but then sequential scan construction?
  • MultiScan defines FileId expression, rewrites and performs constant folding over filter expression?
  • Add support for in_list expressions to DuckDB.
  • Add in_list pruning to layout readers?

gatesn and others added 10 commits July 25, 2025 15:24
@gatesn @robert3005
DuckDB row id
c3d2567
@gatesn @robert3005
Initial
c587f7b
@gatesn @robert3005
Improve work stealing loop
a9ade63 
Signed-off-by: Nicholas Gates <[email protected]>
@gatesn @robert3005
Improve work stealing loop
9767d96 
Signed-off-by: Nicholas Gates <[email protected]>
@gatesn @robert3005
DuckDB Row ID
5bfe768 
Signed-off-by: Nicholas Gates <[email protected]>
@gatesn @robert3005
DuckDB Row ID
4d3043a 
Signed-off-by: Nicholas Gates <[email protected]>
@gatesn @robert3005
DuckDB Row ID
e731719 
Signed-off-by: Nicholas Gates <[email protected]>
@gatesn @robert3005
DuckDB Row ID
24ab5dc 
Signed-off-by: Nicholas Gates <[email protected]>
@gatesn @robert3005
DuckDB Table Filters
6c07731 
Signed-off-by: Nicholas Gates <[email protected]>
@robert3005
fixreabse
6b785f9 
Signed-off-by: Robert Kruszewski <[email protected]>
@robert3005 robert3005 force-pushed the ngates/duckdb-row-id branch from 2970682 to 6b785f9 Compare July 25, 2025 14:45
@coveralls
Copy link

Coverage Status

coverage: 81.749% (-0.04%) from 81.789%
when pulling 6b785f9 on ngates/duckdb-row-id
into 945eb39 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gatesn @coveralls @robert3005