Skip to content

fix(wadm-client): update model list topic to use 'get' instead of 'list' #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(wadm-client): update model list topic to use 'get' instead of 'list' #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628eb67
fix(wadm-client): update model list topic to use 'get' instead of 'list'
jtakakura Aug 9, 2025
9937fa3
Merge branch 'wasmCloud:main' into fix/update-list_manifests
jtakakura Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/wadm-client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ use wadm_types::{
api::{
DeleteModelRequest, DeleteModelResponse, DeleteResult, DeployModelRequest,
DeployModelResponse, DeployResult, GetModelRequest, GetModelResponse, GetResult,
ModelSummary, PutModelResponse, PutResult, Status, StatusResponse, StatusResult,
VersionInfo, VersionResponse,
ListModelsResponse, ModelSummary, PutModelResponse, PutResult, Status, StatusResponse,
StatusResult, VersionInfo, VersionResponse,
},
Manifest,
};
Expand Down Expand Up @@ -129,9 +129,12 @@ impl Client {
.client
.request(topic, Vec::with_capacity(0).into())
.await?;
let body: Vec<ModelSummary> =
let body: ListModelsResponse =
serde_json::from_slice(&resp.payload).map_err(SerializationError::from)?;
Ok(body)
if matches!(body.result, GetResult::Error) {
return Err(ClientError::ApiError(body.message));
}
Ok(body.models)
}

/// Gets a manifest from the lattice by name and optionally its version. If no version is set,
Expand Down
2 changes: 1 addition & 1 deletion crates/wadm-client/src/topics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ impl TopicGenerator {

/// Returns the full topic for a model list operation
pub fn model_list_topic(&self) -> String {
format!("{}.list", self.model_prefix())
format!("{}.get", self.model_prefix())
}

/// Returns the full topic for listing the versions of a model
Expand Down