Skip to content

Stop providing links for invalid paths #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Stop providing links for invalid paths #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tickethelpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,10 @@ def _gettitle(self, ticketnumber):
path, ticketnumber = ticketnumber
url = '%s%s/-/issues/' % (self.url, path)
res = super()._gettitle(ticketnumber, url=url)
# Instead of responding with an HTTP 404 error, GitLab returns the sign in page
# if the repository is either not public or doesn't exist
if (res['title'] == "Sign in · GitLab"):
raise IndexError('Project not found')
res['url'] = url
res['path'] = path
res['ticketnumber'] = ticketnumber
Expand Down