Skip to content

fix: treat HMR's warnUnexpectedRequire as undefined module factory #12016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2025
+12 −6
Merged

fix: treat HMR's warnUnexpectedRequire as undefined module factory #12016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6923cc
fix: treat HMR's `warnUnexpectedRequire` as undefined module factory
stormslowly Oct 28, 2025
63c21c8
Merge branch 'main' into fix/hmr_chunk_apply_race_condition
stormslowly Oct 28, 2025
8fbd0e7
test: update snapshots
stormslowly Oct 29, 2025
c36411f
Merge branch 'main' into fix/hmr_chunk_apply_race_condition
stormslowly Oct 30, 2025
a282fa9
test: adjust test to catch disposed module error
stormslowly Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/rspack_plugin_runtime/src/runtime_module/runtime/javascript_hot_module_replacement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ function applyHandler(options) {
console.warn(
"[HMR] unexpected require(" + module.id + ") to disposed module"
);
throw Error("RuntimeError: factory is undefined(" + module.id + ")");
};

for (var moduleId in currentUpdate) {
Expand Down
3 changes: 2 additions & 1 deletion tests/rspack-test/hotCases/chunks/update-chunk-loading-runtime/__snapshots__/web/1.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
- Bundle: vendors-node_modules_vendor_js.js
- Manifest: runtime~main.LAST_HASH.hot-update.json, size: 76
- Update: main.LAST_HASH.hot-update.js, size: 714
- Update: runtime~main.LAST_HASH.hot-update.js, size: 18966
- Update: runtime~main.LAST_HASH.hot-update.js, size: 19038
- Update: vendors-node_modules_vendor_js.LAST_HASH.hot-update.js, size: 513

## Manifest
Expand Down Expand Up @@ -309,6 +309,7 @@ function applyHandler(options) {
console.warn(
"[HMR] unexpected require(" + module.id + ") to disposed module"
);
throw Error("RuntimeError: factory is undefined(" + module.id + ")");
};

for (var moduleId in currentUpdate) {
Expand Down
3 changes: 2 additions & 1 deletion ...hotCases/disposing/remove-chunk-with-shared-in-other-runtime/__snapshots__/web/1.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
- Bundle: chunk1_js.chunk.CURRENT_HASH.js
- Manifest: [runtime of chunk2_js].LAST_HASH.hot-update.json, size: 60
- Manifest: main.LAST_HASH.hot-update.json, size: 41
- Update: main.LAST_HASH.hot-update.js, size: 18468
- Update: main.LAST_HASH.hot-update.js, size: 18540

## Manifest

Expand Down Expand Up @@ -267,6 +267,7 @@ function applyHandler(options) {
console.warn(
"[HMR] unexpected require(" + module.id + ") to disposed module"
);
throw Error("RuntimeError: factory is undefined(" + module.id + ")");
};

for (var moduleId in currentUpdate) {
Expand Down
3 changes: 2 additions & 1 deletion .../rspack-test/hotCases/disposing/runtime-independent-filename/__snapshots__/web/1.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
## Asset Files
- Bundle: bundle.js
- Bundle: chunk1_js.chunk.CURRENT_HASH.js
- Update: main.LAST_HASH.hot-update.js, size: 18468
- Update: main.LAST_HASH.hot-update.js, size: 18540

## Manifest

Expand Down Expand Up @@ -251,6 +251,7 @@ function applyHandler(options) {
console.warn(
"[HMR] unexpected require(" + module.id + ") to disposed module"
);
throw Error("RuntimeError: factory is undefined(" + module.id + ")");
};

for (var moduleId in currentUpdate) {
Expand Down
3 changes: 2 additions & 1 deletion tests/rspack-test/hotCases/module/access-dropped-module/__snapshots__/web/1.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
## Asset Files
- Bundle: bundle.js
- Manifest: main.LAST_HASH.hot-update.json, size: 42
- Update: main.LAST_HASH.hot-update.js, size: 15415
- Update: main.LAST_HASH.hot-update.js, size: 15487

## Manifest

Expand Down Expand Up @@ -201,6 +201,7 @@ function applyHandler(options) {
console.warn(
"[HMR] unexpected require(" + module.id + ") to disposed module"
);
throw Error("RuntimeError: factory is undefined(" + module.id + ")");
};

for (var moduleId in currentUpdate) {
Expand Down
2 changes: 1 addition & 1 deletion tests/rspack-test/hotCases/runtime/require-disposed-module-warning/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const getInner = require("./module");

it("should print correct warning messages when a disposed module is required", async () => {
await NEXT_HMR();
getInner();
try { getInner(); } catch (e) { }
expectWarning(
/^\[HMR] unexpected require\(\.\/a.js\) from disposed module \.\/module\.js$/,
/^\[HMR] unexpected require\(\.\/a.js\) to disposed module$/
Expand Down
3 changes: 2 additions & 1 deletion tests/rspack-test/hotCases/sharing/share-plugin/__snapshots__/web/1.snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- Bundle: bundle.js
- Bundle: common_js_2.chunk.CURRENT_HASH.js
- Manifest: main.LAST_HASH.hot-update.json, size: 28
- Update: main.LAST_HASH.hot-update.js, size: 42484
- Update: main.LAST_HASH.hot-update.js, size: 42556

## Manifest

Expand Down Expand Up @@ -878,6 +878,7 @@ function applyHandler(options) {
console.warn(
"[HMR] unexpected require(" + module.id + ") to disposed module"
);
throw Error("RuntimeError: factory is undefined(" + module.id + ")");
};

for (var moduleId in currentUpdate) {
Expand Down
Loading