perf: optimize string tensor deserialization with high performance c++ implementation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
reviewed
Aug 4, 2025
| return numpy.attr("empty")(0, py::dtype("object")); | ||
| } | ||
|
|
||
| // First pass: count the number of strings and calculate total size |
There was a problem hiding this comment.
Is this change to mainly optimize string inputs?
kevinthesun
approved these changes
Aug 6, 2025
|
Will there be a merger of this great feature? |
|
@Swipe4057 We are working with Nvidia team on triton-inference-server/server#8348. We have engaged with their engineering team. |
|
Hi @wweic. You should merge to |
|
@yinggeh Yeah, this PR is for personal review with my team. I was waiting for triton team's greenlight to upstream so I can prepare the proper PR to |
|
proper PR to triton repo: triton-inference-server#416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.