Add python 3.12 support and drop 2.7 #73
Open
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays it is not very clear if "2.7" is really valid, and at least uv flags it as an error. Now ">=2.7" is not strictly correct as it includes the 3.0-3.5 range, but finding a way to express that (if there is one) is likely not worth it. Signed-off-by: Yann Dirson <[email protected]>
There is an equivalent License tag already, and uv plainly errors out too on this one. Signed-off-by: Yann Dirson <[email protected]>
This switches away from deprecated `imp`, and breaks support for python 2.7, but I expect this branch to really support only python3 now, so we likely don't care about adding backward compatibility here. Signed-off-by: Yann Dirson <[email protected]>
|
There was no much feedback on this one, is there something I can do to move forward? |
| spec = importlib.util.spec_from_file_location( | ||
| importName, os.path.join(root, filename)) | ||
| module = importlib.util.module_from_spec(spec) | ||
| module.__loader__.exec_module(module) |
There was a problem hiding this comment.
I think it is preferred to use loader rather than __loader__ here. See https://docs.python.org/3.14/library/importlib.html#importlib.machinery.ModuleSpec.loader and the examples in that document.
Otherwise this PR looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches away from deprecated
imp, and breaks support for python 2.7, but I expect this branch to really support only python3 now, so we likely don't care about adding backward compatibility here.Builds on #72