review #2
Closed
review #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ZstdDictionaryCompressor and wire to the read and the write path Resolve a correct dictionary compressor on the read path lazily init ZstdDictCompress and ZstdDictDecompress checksumming Added compression dictionary table and accessors Wire to System table access to CompressionDictionaryManager Integrate dictionary trainer Add nodetool to train dictionary Cleanup break CompressionDictionaryManager up properly release dictionary with reference counting Add ZstdDictionaryCompressorTest Simplify trainer interface Bump SSTable version Add CompressionDictionaryCacheTest Add ZstdDictionaryTrainerTest update to use assertJ Add CompressionDictionaryTrainingConfigTest Update comments in CompressionDictionaryEventHandler and update exception handling in MessagingService Add CompressionDictionaryEventHandlerTest Add CompressionDictionarySchedulerTest Minor update Add CompressionDictionaryManagerTest Add TrainCompressionDictionaryTest (nodetool) Add CompressionDictionaryIntegrationTest Tidy up Add ZstdCompressionDictionaryTest Add SystemDistributedKeyspaceCompressionDictionaryTest Add --sampling-rate for the nodetool Update consistency level from QUORUM to ONE for best effort Add the missing setCompressionDictionaryManager to sstable writer builders Add benchmark
smiklosovic
force-pushed
the
CASSANDRA-17021-yifan
branch
2 times, most recently
from
f76e3e9 to
0496832
Compare
smiklosovic
force-pushed
the
CASSANDRA-17021-yifan
branch
from
0496832 to
ac448a9
Compare
yifan-c
reviewed
Oct 8, 2025
| * @param <T> the specific type of compression dictionary this compressor supports | ||
| */ | ||
| public interface IDictionaryCompressor<T extends CompressionDictionary> | ||
| public interface IDictionaryCompressor<T extends CompressionDictionary> extends ICompressor |
There was a problem hiding this comment.
My thinking on this new interface is to provide new behavior to be mixed into the existing ICompressor (composition). I would like to avoid inheritance here. It is just a preference thing; the effects are the same as far as I can foresee.
yifan-c
force-pushed
the
CASSANDRA-17021/zstd-dict-compression-p1
branch
from
db95727 to
a06d9b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.