Skip to content
This repository was archived by the owner on Jul 2, 2023. It is now read-only.

Add VIP & Campaign in config #114

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Add VIP & Campaign in config #114

wants to merge 26 commits into from

Conversation

@kevingrillet
Copy link
Contributor

@kevingrillet kevingrillet commented Sep 27, 2021

Fix #104 & #103

@kevingrillet kevingrillet added Priority: Low ❄️ Don't worry, at least for now. But don't forget about it! File: deploy.sh 📁 Everything deploy.sh related. File: afk-daily.sh 📁 Everything afk-daily.sh related. File: config.ini 📁 Everything config.ini related. labels Sep 27, 2021
@kevingrillet kevingrillet self-assigned this Sep 27, 2021
@kevingrillet kevingrillet linked an issue Sep 27, 2021 that may be closed by this pull request
Low level oak inn not working #103
Open
Zebiano
Zebiano suggested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@Zebiano Zebiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the string problem, all seems to be fine. If possible, could you also update endAt and guildBattleType to be of type string as well?

Zebiano and others added 2 commits September 29, 2021 22:03
@Zebiano
Update Config.md
8918dee
@kevingrillet
Add campaignChapter
f93355c 
- Add af-daily > requiredLevel
- Deploy > checkConfig
- Switch to campaignChapter and campaignStage
@kevingrillet
Copy link
Contributor Author

kevingrillet commented Oct 21, 2021

Should work, but need to be tested ;)

@kevingrillet kevingrillet linked an issue Oct 22, 2021 that may be closed by this pull request
Support guild hunts for low-level players #118
Open
@kevingrillet
Copy link
Contributor Author

kevingrillet commented Oct 23, 2021

After merge with #133 will require to update the wiki examples 😉

@kevingrillet kevingrillet added the Status: In progress 🕥 Tell them you're working on it... They'll believe you! label Oct 23, 2021
kevingrillet
kevingrillet commented Oct 24, 2021
View reviewed changes
kevingrillet
kevingrillet commented Oct 24, 2021
View reviewed changes
kevingrillet
kevingrillet commented Oct 24, 2021
View reviewed changes
@kevingrillet kevingrillet requested a review from Zebiano October 25, 2021 06:09
Zebiano
Zebiano suggested changes Oct 25, 2021
View reviewed changes
Zebiano
Zebiano reviewed Oct 25, 2021
View reviewed changes
@Zebiano
Update: Oak Inn function checks
ee0ef4d 
Add: Info to terminal
Update: Format files
@Zebiano
Copy link
Member

Zebiano commented Oct 25, 2021 •
edited
Loading

Note to self:

  • Update Wiki page AFK Arena requirements with correct values found here.

@kevingrillet
Copy link
Contributor Author

kevingrillet commented Jan 6, 2022

I'll work on it next week if my test account gets back to work.
But I think we already did 99% of the work.

@Zebiano
Copy link
Member

Zebiano commented Jan 17, 2022 •
edited
Loading

I've been taking a look at this, and I think I want to make it a bit more different. I'd rather have a function dedicated to checking everything related to required levels/stages before executing the init function, rather than cluttering up the main "if doAction then doAction" section of the file with requirement checks.

I'm still unsure if we should exit the script if we found stuff the user has invalid requirements, or take other actions instead. I've decided to let the script take actions automatically. This means the script will warn the user "Yo, I can't do that!" and then proceed to either do something that it can do or skip it. I think this is the best approach, as else it would defeat the purpose of having a feature that checks for player levels, etc, as it would simply be annoying for everyone and no one would make use of it.

I'll take care of it this week hopefully!

@Zebiano
Add: Logic for various requiredLevel checks
da73cf9 
Update: Default `endAt` entry is now `campaign`
Update: `eventHoe=true`
Add: `runOakSpeedy` variable for the script to know when to run `oakInn_Speedy`
@Zebiano
Merge branch 'master' into pr/114
74ca07f
@Zebiano
Fix: HEX values on oakInn_Old
442282d 
Update: Timings
Update: Function `requiredLevel()` doesn't differentiate between stage `0` and `1`, which means it's possible to set a VIP and Chapter level without setting a stage
@Zebiano
Copy link
Member

Zebiano commented Jan 31, 2022 •
edited
Loading

Alright, the PR is basically done now: VIP, Chapter and Stage are now settable in the config, and it also fixes (hopefully) #118 and #103. It could be merged like this, yet it's fairly simple to implement the rest of the necessary changes to take lower-level Players into consideration, so I'm considering doing that. I guess my plan is to create some more issues and then either fix them on this PR or "per issue" in the future.

@kevingrillet kevingrillet assigned Zebiano and unassigned kevingrillet Mar 24, 2022
@Zebiano Zebiano mentioned this pull request Mar 28, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Zebiano Zebiano Zebiano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Zebiano Zebiano

Labels

File: afk-daily.sh 📁 Everything afk-daily.sh related. File: config.ini 📁 Everything config.ini related. File: deploy.sh 📁 Everything deploy.sh related. Priority: Low ❄️ Don't worry, at least for now. But don't forget about it! Status: In progress 🕥 Tell them you're working on it... They'll believe you!

Projects

None yet

Milestone

Support lower level players

Development

Successfully merging this pull request may close these issues.

Support guild hunts for low-level players Add variable for users to define current VIP level and Campaign stage Low level oak inn not working

2 participants

@kevingrillet @Zebiano