fix: essentials and pinned removed on ctrl-tab #9012 #11333
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d tabs in ctrl-tab menu
dosubot
bot
added
size:M
Contributor
Author
|
|
mr-cheffy
requested changes
Nov 18, 2025
Member
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
Looks good, some minor changes, could you please guide me on how you would remove a tab from the ctrl+tab menu though?
| - gBrowser.removeTab(aPreview._tab); | ||
| + const tab = aPreview._tab; | ||
| + | ||
| + if (tab.hasAttribute("zen-essential") || tab.pinned) { |
Member
There was a problem hiding this comment.
All essentials already have tab.pinned guaranteed.
| + new KeyboardEvent('keydown', { key: 'w', ctrlKey: true }), | ||
| + tab | ||
| + ); | ||
| + // Manually update UI since unloading doesn't trigger TabClose |
Member
There was a problem hiding this comment.
Please remove the comments, to reduce patch sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
✅ Detects essential/pinned tabs
✅ Routes them through onCloseTabShortcut to unload instead of remove
✅ Updates the Ctrl+Tab UI properly (removes preview, updates list)
Fixes #9012