feat: Enable original extensions panel on hide-unified-extensions-button: false #11335
Conversation
dosubot
bot
added
size:L
There was a problem hiding this comment.
Instead of choosing what panel should be used every time, we could just revert these changes if the preference is off:
desktop/src/browser/base/content/browser-addons-js.patch
Lines 44 to 52 in 0899621
Or at least simply override it? gUnifiedExtensions._panel = ...
| align-items: center; | ||
| padding: 10px 9px; | ||
| padding-bottom: 0; | ||
| padding-bottom: 8px; |
There was a problem hiding this comment.
This should only be set if the preference is enabled?
There was a problem hiding this comment.
I'll defer to you on that.
For context, the reason I added it was for tabs like about:config where only the toolbar buttons are shown now when hide-unified-extensions-button: false
Example
It does make the spacing between sections a little more consistent. But I can add the gating if you'd like.
-
Before
-
After
| #unified-extensions-button:not([showing]) { | ||
| display: none !important; | ||
| @media not -moz-pref('zen.theme.hide-unified-extensions-button') { | ||
| .zen-site-data-section:has(#unified-extensions-manage-extensions) { |
There was a problem hiding this comment.
Don't use :has, better set an attribute to the section that contains the addons list
Yes, that's true. Effectively that's what |
|
|
||
| case "toolbarvisibilitychange": | ||
| - this.onToolbarVisibilityChange(event.target.id, event.detail.visible); | ||
| + this.onToolbarVisibilityChange(event.target.id, event.detail.visible, panel); |
There was a problem hiding this comment.
You are still passing panel as an argument though?
| this.extensionsPanelView = 'original-unified-extensions-view'; | ||
|
|
||
| if (!Services.prefs.getBoolPref('zen.theme.hide-unified-extensions-button', true)) { | ||
| this.window.gUnifiedExtensions._panel = this.extensionsPanel = this.#initExtensionsPanel(); |
There was a problem hiding this comment.
We technically don't need to run this as the default panel for the gUnifiedExtensions is already the extensions panel
There was a problem hiding this comment.
@blakegearin I wonder, if you simply return past this point, how does firefox react? Does it start using the old popup?
2 participants
Summary
Updated
ZenSiteDataPanel.sys.mjsto support multiple panels and pass relevant objects tobrowser-addons.jsPatched
browser-addons.jsto accept panel objectsPatched
navigator-toolbox.jsto get panel objects fromwindow.gZenSiteDataPanelUpdated
zen-single-components.cssto conditionally hide extensions on unified panelScreenshots
hide-unified-extensions-button: truehide-unified-extensions-button: falseNotes
hide-unified-extensions-buttondoes require a browser restart to fully take effect and swich over. This is because the list of extensions are added on browser initialization. It does not appearbrowser/components/customizableui/CustomizableUI.sys.mjsis able to natively support adding and removing extensions from multiple areas