Skip to content

Conversation

ntavish
Copy link

@ntavish ntavish commented Jun 12, 2025

Adds soc init code including MPU configuration and PLL errata handling for the TI Hercules family SoC TMS570LC43xx. Portions of this code were taken or adapter from Halcogen code generator.

This HAL is not really complete, as the currently implemented drivers do not depend on Halcogen and so were not needed. Main reason for this PR is the code license (BSD 3 clause).

This PR is related to this one on zephyr which adds support for TMS570: zephyrproject-rtos/zephyr#88741

@ntavish
Copy link
Author

ntavish commented Jul 16, 2025

@vaishnavachath hello, can I request you to take a look at this PR as it block another PR in zephyr to add a new board. No hurry, but the original PR has been going on for quite a while now!

*
* These functions are adapted from TI Halcogen generated code.
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntavish can you please combine the both copyright statements together?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ntavish ntavish force-pushed the feature/add-tms570lc43-halcogen-code branch from 9d1ece5 to 30d1509 Compare August 18, 2025 04:44
@ssekar15
Copy link
Collaborator

@ntavish could you give more details why soc related zephyr code in HAL, e.g dts information its zephyr macro?
Readme has no information about source and steps to bring this changes

@ssekar15 ssekar15 self-requested a review August 19, 2025 05:37
@ntavish
Copy link
Author

ntavish commented Aug 19, 2025

@ntavish could you give more details why soc related zephyr code in HAL, e.g dts information its zephyr macro? Readme has no information about source and steps to bring this changes

Hello, the only reason to move this code to ti_hal is licensing, this is adapted from HALcoGen output, and I cannot relicense it. The only possible way to inlclude this is in zephyr seems to be to move it here. TMS570/hercules does not provide a HAL per se, only generated output from HALCoGen. Please check the related PR as well zephyrproject-rtos/zephyr#88741

Some files can be cleaned up to remove unnecessary includes from zephyr, and the dts macro could be moved to zephyr side - let me update the PR to improve that.

Adds soc init code including MPU configuration and PLL errata
handling for the TI Hercules family SoC TMS570LC43xx. Portions
of this code were taken or adapter from Halcogen code generator.

This HAL is not really complete, as the currently implemented
drivers do not depend on Halcogen and so were not needed.

Signed-off-by: Tavish Naruka <[email protected]>
@ntavish ntavish force-pushed the feature/add-tms570lc43-halcogen-code branch from 30d1509 to 43c7050 Compare September 1, 2025 14:37
@ntavish
Copy link
Author

ntavish commented Sep 1, 2025

Moved the Apache 2.0 licensed headers out of here and added some description in a README as requested. (updated the zephyr side PR for TMS570 as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants