Skip to content

chore: use kiteVersion property consistently for X-Kite-Version headers #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

chore: use kiteVersion property consistently for X-Kite-Version headers #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/KiteConnect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,7 +1491,7 @@ private function request(string $route, string $method, array $params, string $h
$request_headers = [
"Content-Type" => $content_type,
"User-Agent" => "phpkiteconnect/" . self::VERSION,
"X-Kite-Version" => 3,
"X-Kite-Version" => $this->kiteVersion,
];

if ($this->apiKey && $this->accessToken) {
Expand Down
10 changes: 5 additions & 5 deletions tests/KiteTickerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function setUp(): void
}

/**
* Test LTP mode tick data - matches TypeScript ltpModeTick test
* Test LTP mode tick data
*/
public function testLtpModeTick()
{
Expand All @@ -35,7 +35,7 @@ public function testLtpModeTick()
}

/**
* Test Quote mode tick data - matches TypeScript quoteModeTick test
* Test Quote mode tick data
*/
public function testQuoteModeTick()
{
Expand All @@ -54,7 +54,7 @@ public function testQuoteModeTick()
}

/**
* Test Full mode tick data - matches TypeScript fullModeTick test
* Test Full mode tick data
*/
public function testFullModeTick()
{
Expand All @@ -73,15 +73,15 @@ public function testFullModeTick()
}

/**
* Read binary packets - matches TypeScript readBufferPacket function
* Read binary packets
*/
private function readBufferPacket(string $fileName): string
{
return file_get_contents(__DIR__ . '/' . $fileName);
}

/**
* Convert buffer to binary buffer array - matches TypeScript toArrayBuffer function
* Convert buffer to binary buffer array
*/
private function toArrayBuffer(string $tickerMode): string
{
Expand Down
Loading