Skip to content

Added installSignalHandlers as an argument to KiteTicker.connect() #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added installSignalHandlers as an argument to KiteTicker.connect() #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
169305d
Added installSignalHandlers as an argument to KiteTicker.connect()
Feb 9, 2024
2c4a87b
Changed solution to daemon flag for thread
Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kiteconnect/ticker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,13 +493,14 @@ def _create_connection(self, url, **kwargs):
def _user_agent(self):
return (__title__ + "-python/").capitalize() + __version__

def connect(self, threaded=False, disable_ssl_verification=False, proxy=None):
def connect(self, threaded=False, disable_ssl_verification=False, proxy=None, daemon=True):
"""
Establish a websocket connection.

- `threaded` is a boolean indicating if the websocket client has to be run in threaded mode or not
- `disable_ssl_verification` disables building ssl context
- `proxy` is a dictionary with keys `host` and `port` which denotes the proxy settings
- `installSignalHandlers` is a boolean indicating if signal handlers should be installed or not. Ignored if `threaded` is True
"""
# Custom headers
headers = {
Expand Down Expand Up @@ -531,7 +532,7 @@ def connect(self, threaded=False, disable_ssl_verification=False, proxy=None):
# Signals are not allowed in non main thread by twisted so suppress it.
opts["installSignalHandlers"] = False
self.websocket_thread = threading.Thread(target=reactor.run, kwargs=opts)
self.websocket_thread.daemon = True
self.websocket_thread.daemon = daemon
self.websocket_thread.start()
else:
reactor.run(**opts)
Expand Down