-
Notifications
You must be signed in to change notification settings - Fork 53
Allow setting fiber orientation with mesh data in the mixture module #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amgebauer
wants to merge
1
commit into
4C-multiphysics:main
Choose a base branch
from
amgebauer:allow-setting-fiber-orientation-with-mesh-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // This file is part of 4C multiphysics licensed under the | ||
| // GNU Lesser General Public License v3.0 or later. | ||
| // | ||
| // See the LICENSE.md file in the top-level for license information. | ||
| // | ||
| // SPDX-License-Identifier: LGPL-3.0-or-later | ||
|
|
||
| #ifndef FOUR_C_MAT_FIBER_INTERPOLATION_HPP | ||
| #define FOUR_C_MAT_FIBER_INTERPOLATION_HPP | ||
|
|
||
| #include "4C_config.hpp" | ||
|
|
||
| #include "4C_linalg_tensor.hpp" | ||
|
|
||
| #include <numeric> | ||
| #include <ranges> | ||
|
|
||
|
|
||
| FOUR_C_NAMESPACE_OPEN | ||
|
|
||
| namespace Mat | ||
| { | ||
| /** | ||
| * A simple interpolation strategy for unit-vector fields (e.g., fibers) | ||
| */ | ||
| struct FiberInterpolation | ||
| { | ||
| Core::LinAlg::Tensor<double, 3> operator()(const std::ranges::sized_range auto& weights, | ||
| const std::ranges::sized_range auto& fibers) const | ||
| { | ||
| // Do default interpolation | ||
| Core::LinAlg::Tensor<double, 3> interpolated_fiber = std::inner_product(weights.begin(), | ||
| weights.end(), fibers.begin(), Core::LinAlg::Tensor<double, 3>{{0.0, 0.0, 0.0}}); | ||
|
|
||
| // normalize vector | ||
| return interpolated_fiber / Core::LinAlg::norm2(interpolated_fiber); | ||
| } | ||
| }; | ||
|
|
||
| } // namespace Mat | ||
|
|
||
| FOUR_C_NAMESPACE_CLOSE | ||
|
|
||
| #endif | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Division by zero can occur if
interpolated_fiberhas zero norm (e.g., when all input fibers are zero vectors or weights sum to zero). Add a check for zero norm before division or document the precondition that the norm must be non-zero.