Skip to content

add context parameter to onCost, to allow logging operation name #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2018
Merged

add context parameter to onCost, to allow logging operation name #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f843600
add context parameter to onCost to allow better logging
ozzieba Oct 8, 2018
a4269bf
fix test
ozzieba Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export function createComplexityLimitRule(
const cost = visitor.getCost();

if (onCost) {
onCost(cost);
onCost(cost, context);
}

if (cost > maxCost) {
Expand Down
8 changes: 4 additions & 4 deletions test/createComplexityLimitRule.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { GraphQLError, parse, validate } from 'graphql';
import { GraphQLError, parse, validate, ValidationContext } from 'graphql';

import { createComplexityLimitRule } from '../src';

Expand Down Expand Up @@ -53,7 +53,7 @@ describe('createComplexityLimitRule', () => {
]);

expect(errors).toHaveLength(0);
expect(onCostSpy).toHaveBeenCalledWith(1);
expect(onCostSpy).toHaveBeenCalledWith(1, expect.any(ValidationContext));
});

it('should call onCost with complexity score on an SDL schema', () => {
Expand All @@ -72,7 +72,7 @@ describe('createComplexityLimitRule', () => {
]);

expect(errors).toHaveLength(0);
expect(onCostSpy).toHaveBeenCalledWith(51);
expect(onCostSpy).toHaveBeenCalledWith(51, expect.any(ValidationContext));
});

it('should call onCost with cost when there are errors', () => {
Expand All @@ -91,7 +91,7 @@ describe('createComplexityLimitRule', () => {
]);

expect(errors).toHaveLength(1);
expect(onCostSpy).toHaveBeenCalledWith(10);
expect(onCostSpy).toHaveBeenCalledWith(10, expect.any(ValidationContext));
});

it('should call formatErrorMessage with cost', () => {
Expand Down