Support createError #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag04
reviewed
Jul 27, 2017
| formatErrorMessage(cost), [node], | ||
| )); | ||
| context.reportError( | ||
| createError ? |
Contributor
There was a problem hiding this comment.
most users would want to just format the error object provided? attach metadata to it etc.
y not just do formatError(error: graphqlError) ?
Contributor
There was a problem hiding this comment.
meh! it's just about an extra require but i guess doesn't matter much.
Contributor
Author
There was a problem hiding this comment.
It's just a cleaner API. "Modify this error message that someone else created" is not a great look.
chirag04
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.