boot:dts:aspeed: intial support for SP8 board #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added base dts file for eagle and hornbill Signed-off-by: [email protected] <[email protected]>
rajaganeshr
reviewed
Sep 25, 2025
| @@ -0,0 +1,1097 @@ | |||
| // SPDX-License-Identifier: GPL-2.0 | |||
| // Copyright (c) 2024 AMD Inc. | |||
| reusable; | ||
| }; | ||
|
|
||
| pcc_memory: pccbuffer { |
There was a problem hiding this comment.
we don't need pcc_memory anymore in 27x0. We can remove this node
modolaty
reviewed
Oct 7, 2025
| #size-cells = <0>; | ||
| }; | ||
|
|
||
| P0_conn_012_mgmt: i2c@2 { |
There was a problem hiding this comment.
Nit: spacing needs cleanup
modolaty
reviewed
Oct 7, 2025
| }; /* i2cswitch@71 */ | ||
| }; /* P0_conn_012_mgmt: i2c@2 */ | ||
|
|
||
| P0_conn_345_mgmt: i2c@3 { |
There was a problem hiding this comment.
nit: spacing need cleanup
modolaty
reviewed
Oct 7, 2025
| }; /* i2cswitch@71 */ | ||
| }; /* P0_conn_345_mgmt: i2c@3 */ | ||
|
|
||
| fan_pdb: i2c@4 { |
There was a problem hiding this comment.
fan_pdb is on port 5 (i2c@5, and reg = <5>
modolaty
reviewed
Oct 7, 2025
| }; | ||
| }; | ||
|
|
||
| P0_pcp: i2c@5 { |
There was a problem hiding this comment.
either change it to Port 4, or remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added base dts file for eagle and hornbill