Skip to content

Conversation

@joeybaker
Copy link
Contributor

Latest React Native releases require Flow 0.47. That version
catches issues that Flow 0.33 which this repo is locked to doesn't.
This PR upgrades Flow and fixes those issues.

@joeybaker
Copy link
Contributor Author

Travis is failing because eslint can't find builtin flow types. I think you can fix this with https://www.npmjs.com/package/eslint-plugin-flowtype

@joeybaker
Copy link
Contributor Author

Installed that plugin as a part of this PR.

Copy link
Collaborator

@alvaromb alvaromb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Swordsman-Inaction Swordsman-Inaction merged commit f4805f2 into APSL:master Jul 26, 2017
@joeybaker
Copy link
Contributor Author

Thanks! Any chance of an updated npm version?

@Swordsman-Inaction
Copy link
Collaborator

@joeybaker Will release a new version after most PRs are merged. Won't be long.

@alvaromb
Copy link
Collaborator

alvaromb commented Aug 9, 2017

Released! https://github.com/APSL/react-native-keyboard-aware-scroll-view/releases/tag/v0.3.0

@alvaromb
Copy link
Collaborator

alvaromb commented Aug 9, 2017

Sorry for the delay guys, tons of work ATM

@joeybaker joeybaker deleted the flow-fixes branch August 9, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants