Add support to subscribe to keyboard events #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the PR @leonardocarvalho ? |
|
Fix this and merge asap |
leonardocarvalho
force-pushed
the
master
branch
2 times, most recently
from
01d9e54 to
5d9d8b7
Compare
|
Sorry for the delay. I don't have the time to manually test it right now. Will try to do it tonight. |
leonardocarvalho
force-pushed
the
master
branch
3 times, most recently
from
fbcc441 to
4fa18c4
Compare
This commit is not strictly necessary, once lib users can make their own subscribe to `Keyboard` events. On the other hand, this helps everything related to keyboard to be on the same place. Also, this commit makes the lib compliant with its documentation, which state that `onKeyboardWillShow` is a possible prop for the component.
leonardocarvalho
force-pushed
the
master
branch
from
4fa18c4 to
31535e4
Compare
|
Any updates on this? |
|
@evanjmg how do you feel about being a collaborator? Need a hand to keep updating the gazillion repos I have ATM. |
alvaromb
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is not strictly necessary, once lib users can make their own subscribe
to
Keyboardevents. On the other hand, this helps everything related to keyboardto be on the same place.
Also, this commit makes the lib compliant with its documentation, which state that
onKeyboardWillShowis a possible prop for the component.