Skip to content

fix enableAutoAutomaticScroll prop #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2018
Merged

fix enableAutoAutomaticScroll prop #215

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e342bff
fix enableAutoAutomaticScroll prop
antoinegrelard Jan 12, 2018
bc5a3ae
update enableAutoAutomaticScroll prop name to enableAutomaticScroll
antoinegrelard Jan 19, 2018
26ba359
Merge branch 'master' into fix-enable-autoscroll
antoinegrelard Jan 19, 2018
936a7ff
Merge branch 'master' into fix-enable-autoscroll
antoinegrelard Jan 19, 2018
2fd24ed
fix prettier formatting
antoinegrelard Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions lib/KeyboardAwareHOC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,13 @@ function listenToKeyboardEvents(ScrollableComponent: React$Component) {

// Keyboard actions
_updateKeyboardSpace = (frames: Object) => {
let keyboardSpace: number =
frames.endCoordinates.height + this.props.extraScrollHeight
if (this.props.viewIsInsideTabBar) {
keyboardSpace -= _KAM_DEFAULT_TAB_BAR_HEIGHT
}
this.setState({ keyboardSpace })
// Automatically scroll to focused TextInput
if (this.props.enableAutoAutomaticScroll) {
Copy link
Collaborator

@alvaromb alvaromb Jan 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Can you rename this prop to the intended name? It should be enableAutomaticScroll, not enableAutoAutomaticScroll (note the extra Auto). This has been an error I've introduced myself, but it would be great to change it with this PR.

let keyboardSpace: number = frames.endCoordinates.height + this.props.extraScrollHeight
if (this.props.viewIsInsideTabBar) {
keyboardSpace -= _KAM_DEFAULT_TAB_BAR_HEIGHT
}
this.setState({ keyboardSpace })
const currentlyFocusedField = TextInput.State.currentlyFocusedField()
const responder = this.getScrollResponder()
if (!currentlyFocusedField || !responder) {
Expand Down