Reseting keyboard space to default keyboard space after keyboard dismiss #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvaromb Can u pls review this PR once? |
alvaromb
reviewed
Apr 6, 2018
|
I have the same problem with the extraScrollHeight leaving a blank space at the bottom after the keyboard is dismissed. @alvaromb can you take a look at this again? Thanks a lot! |
alvaromb
requested changes
Jul 16, 2018
|
Have there been any updates on this? I'm running into this issue myself. |
alvaromb
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrollable content was taking extra space equal to extra scroll height once the keyboard was opened and closed again. The keyboardSpace should be reset after keyboard closes which was not the case earlier. The PR contains fix to the above scenario.