-
Notifications
You must be signed in to change notification settings - Fork 644
Component driven update method #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds an `update` method to allow components the ability to re-scroll to the selected field based on some user-defined event. Fixes issues that most users are having with auto-growing, resizing, updated or multiline `TextInput` fields. Examples and Videos description closes APSL#250
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be awesome if we could get this merged. 💯
@alvaromb
|
Super cool! Will merge & release today. Thanks! |
|
Any update on when this PR will be merged and released? |
|
@Landcross today is the day! |
|
This is really great! Non multiline textinputs works fine. Any ideas of where to start debugging? Edit: I'm on RN 0.56 |
|
Confirming doesn't work in 0.56 |
|
I'm on RN 0.53 and KeyboardAwareFlatList is working, but KeyboardAwareScrollView isn't. @bugs181 - Any ideas why this wouldn't apply to all of the components? |
|
I can confirm it doesn't work for |
|
EDIT: |
|
Working for me on 0.57.1, however the inputs must be controlled inputs in order to update the state of the component, thus triggering the scroll view update. Here's my environment info: |
|
Apologies to everyone! It appears Github notifications are on the fritz again. I never received any notifications regarding this thread. I haven't had the opportunity to check what broke in recent releases however have an idea. Recently React has been deprecating lifecycles and changing how some of them behave. That said, some of you are asking why this does not apply to inputs that aren't "controlled". The PR was originally only intended to update the input that the user is focused on. When/If I have time in the near future, I'll look for an alternative method in KASV to retrieve the input you're intending to update. |
Adds an
updatemethod to allow components the ability to re-scroll to the selected field based on some user-defined event.Fixes issues that most users are having with auto-growing, resizing, updated or multiline
TextInputfields.Videos
Without fix:
With fix:
Example use:
In component file:
closes #250