When enableResetScrollToCoords is not false, use this.props.resetScro… #309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that passing the prop resetScrollToCoords didn't seem to have an effect, it kept scrolling to 0, 0 whatever I passed in.
I looked into the code and saw that the _resetKeyboardSpace in KeyboardAwareHOC was checking for this.resetCoords if this.props.enableResetScrollToCoords was not equal to false and then falling back to defaultResetScrollToCoords if defined, otherwise it simply scrolled to 0,0.
I failed to find any place where resetCoords is set and I assume what we want to use here are the coordinates passed through the resetScrollToCoords prop.
The suggested fix in this pull request gives me the results I would expect for the following scenarios: